From patchwork Fri Nov 16 06:50:35 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tushar Behera X-Patchwork-Id: 1753431 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 2D7343FCDE for ; Fri, 16 Nov 2012 07:00:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751382Ab2KPG5J (ORCPT ); Fri, 16 Nov 2012 01:57:09 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:37736 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751364Ab2KPG5H (ORCPT ); Fri, 16 Nov 2012 01:57:07 -0500 Received: by mail-pb0-f46.google.com with SMTP id wy7so1734370pbc.19 for ; Thu, 15 Nov 2012 22:57:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=Oz/5ME2M1zZ8LS+0FzymWYxH8QCPVyjxctyq94IkSmM=; b=BPYqdTAOp8u79BdAVFLidjjZvJeUV7n1A2KEJc6HnHKQUkjPGcX1oYYEeSqfcotCC5 HtM/L4jaRTKEejSi9KA6ctRTc2cRn0QFta3pcZo2a8MVYrf/CSi88x6K9X8zBco182oG aQ6CeGo21flrE9EQ0HK0JeyfmyKwY9lcXFHgTmdaYsLVt1kWqLp1y+ZwS6g1ozC11mHp RKo5S5Mny2R2l9JYIpX9Os4pG0VTqLaevp0hhhS01XHGxvj0fQPpICqFy4A5fA5TlqxY Dks5SopZM3cVdamuMKUqLZZ06SekT6o/EYC2KuI2Xv/QCBMTmOpv39CDD0qw+IAOiPrq PxcQ== Received: by 10.66.77.199 with SMTP id u7mr10383021paw.7.1353049027518; Thu, 15 Nov 2012 22:57:07 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id mz10sm753915pbc.37.2012.11.15.22.57.04 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 15 Nov 2012 22:57:06 -0800 (PST) From: Tushar Behera To: linux-kernel@vger.kernel.org Cc: patches@linaro.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: [PATCH 03/14] [media] saa7134: Remove redundant check on unsigned variable Date: Fri, 16 Nov 2012 12:20:35 +0530 Message-Id: <1353048646-10935-4-git-send-email-tushar.behera@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1353048646-10935-1-git-send-email-tushar.behera@linaro.org> References: <1353048646-10935-1-git-send-email-tushar.behera@linaro.org> X-Gm-Message-State: ALoCoQnOIxDRlRsPDpt8pYJchWLho3wFrYhyBHDDmcH71WcMvjqKfiGkQvePAew/RjU9YUuOvkV1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org No need to check whether the unsigned variable is less than 0. CC: Mauro Carvalho Chehab CC: linux-media@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/media/pci/saa7134/saa7134-video.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/pci/saa7134/saa7134-video.c b/drivers/media/pci/saa7134/saa7134-video.c index 4a77124..3abf527 100644 --- a/drivers/media/pci/saa7134/saa7134-video.c +++ b/drivers/media/pci/saa7134/saa7134-video.c @@ -2511,7 +2511,7 @@ int saa7134_video_init1(struct saa7134_dev *dev) /* sanitycheck insmod options */ if (gbuffers < 2 || gbuffers > VIDEO_MAX_FRAME) gbuffers = 2; - if (gbufsize < 0 || gbufsize > gbufsize_max) + if (gbufsize > gbufsize_max) gbufsize = gbufsize_max; gbufsize = (gbufsize + PAGE_SIZE - 1) & PAGE_MASK;