| Message ID | 1353048646-10935-5-git-send-email-tushar.behera@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
diff --git a/drivers/media/usb/tlg2300/pd-video.c b/drivers/media/usb/tlg2300/pd-video.c index 1f448ac..dd157e7 100644 --- a/drivers/media/usb/tlg2300/pd-video.c +++ b/drivers/media/usb/tlg2300/pd-video.c @@ -923,7 +923,7 @@ static int vidioc_s_input(struct file *file, void *fh, unsigned int i) struct poseidon *pd = front->pd; s32 ret, cmd_status; - if (i < 0 || i >= POSEIDON_INPUTS) + if (i >= POSEIDON_INPUTS) return -EINVAL; ret = send_set_req(pd, SGNL_SRC_SEL, pd_inputs[i].tlg_src, &cmd_status);
No need to check whether unsigned variable is less than 0. CC: Mauro Carvalho Chehab <mchehab@infradead.org> CC: linux-media@vger.kernel.org Signed-off-by: Tushar Behera <tushar.behera@linaro.org> --- drivers/media/usb/tlg2300/pd-video.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)