From patchwork Wed Nov 28 19:09:20 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sylwester Nawrocki/Kernel \\(PLT\\) /SRPOL/Staff Engineer/Samsung Electronics" X-Patchwork-Id: 1817981 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id DDC02DF26F for ; Wed, 28 Nov 2012 19:09:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932193Ab2K1TJr (ORCPT ); Wed, 28 Nov 2012 14:09:47 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:46811 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755792Ab2K1TJq (ORCPT ); Wed, 28 Nov 2012 14:09:46 -0500 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0ME700HZQP81F3B0@mailout2.samsung.com> for linux-media@vger.kernel.org; Thu, 29 Nov 2012 04:09:45 +0900 (KST) X-AuditID: cbfee61b-b7f616d00000319b-6f-50b661781fc8 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id DD.A6.12699.97166B05; Thu, 29 Nov 2012 04:09:45 +0900 (KST) Received: from amdc1344.digital.local ([106.116.147.32]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0ME7006TUP7TOU90@mmp2.samsung.com> for linux-media@vger.kernel.org; Thu, 29 Nov 2012 04:09:44 +0900 (KST) From: Sylwester Nawrocki To: linux-media@vger.kernel.org Cc: sw0312.kim@samsung.com, kyungmin.park@samsung.com, a.hajda@samsung.com, Sylwester Nawrocki Subject: [PATCH RFC 03/12] fimc-lite: Register dump function cleanup Date: Wed, 28 Nov 2012 20:09:20 +0100 Message-id: <1354129766-2821-4-git-send-email-s.nawrocki@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1354129766-2821-1-git-send-email-s.nawrocki@samsung.com> References: <1354129766-2821-1-git-send-email-s.nawrocki@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIJMWRmVeSWpSXmKPExsVy+t9jQd3KxG0BBs/uslv0bNjK6sDo8XmT XABjFJdNSmpOZllqkb5dAlfG5vd7mQtWcFQ8ezCPtYGxhb2LkZNDQsBE4uSGyVC2mMSFe+vZ uhi5OIQEpjNKzL75G8pZwSSx6v48RpAqNgFDid6jfWC2iIC8xJPeG2wgNrNApcTJ+bOZQGxh AReJ9Z+vs4LYLAKqElsXnQWr5xVwldi/4DBLFyMH0DYFiTmTbEDCnAJuEudvPAArEQIq+Xyl iWkCI+8CRoZVjKKpBckFxUnpuUZ6xYm5xaV56XrJ+bmbGMEefya9g3FVg8UhRgEORiUe3o2W 2wKEWBPLiitzDzFKcDArifDeCgIK8aYkVlalFuXHF5XmpBYfYpTmYFES5232SAkQEkhPLEnN Tk0tSC2CyTJxcEo1MEo85TjT17Dw8809mR9SDVZNuXJW9sy2Ry9N/5+ao//yQteJq8t+zom5 pRZg+25+T+6NXQKfyr2jHLpKz4a9l9ctv7zrs5Xs4o33tlW/3Pj/0sJ/F//z9el+f20qsmd1 J49WIWuflfOnxv7KS9MWTzJi5nq8IHDDy98XpgvsPiz/etKef0XBYmoXlFiKMxINtZiLihMB 4Q93dvQBAAA= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Use v4l2_info() to make it possible to identify which FIMC-LITE device instance the logs refer to. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-fimc/fimc-lite-reg.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p-fimc/fimc-lite-reg.c b/drivers/media/platform/s5p-fimc/fimc-lite-reg.c index a22d7eb..ad63ebf 100644 --- a/drivers/media/platform/s5p-fimc/fimc-lite-reg.c +++ b/drivers/media/platform/s5p-fimc/fimc-lite-reg.c @@ -292,9 +292,11 @@ void flite_hw_dump_regs(struct fimc_lite *dev, const char *label) }; u32 i; - pr_info("--- %s ---\n", label); + v4l2_info(&dev->subdev, "--- %s ---\n", label); + for (i = 0; i < ARRAY_SIZE(registers); i++) { u32 cfg = readl(dev->regs + registers[i].offset); - pr_info("%s: %s:\t0x%08x\n", __func__, registers[i].name, cfg); + v4l2_info(&dev->subdev, "%9s: 0x%08x\n", + registers[i].name, cfg); } }