diff mbox

[RFC,06/13] of: Add empty of_find_device_by_node() function definition

Message ID 1355168499-5847-7-git-send-email-s.nawrocki@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

This allows users to be compiled without excluding this function
call with preprocessor directives when CONFIG_OF_DEVICE is disabled.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 include/linux/of_platform.h |    7 +++++++
 1 file changed, 7 insertions(+)

Comments

Grant Likely Dec. 11, 2012, 8:59 a.m. UTC | #1
On Mon, 10 Dec 2012 20:41:32 +0100, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote:
> This allows users to be compiled without excluding this function
> call with preprocessor directives when CONFIG_OF_DEVICE is disabled.
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>

Same question here... Okay, I'll stop replying to these now. :-) When
you repost, for each one of these please tell me why the empty version
is needed. ie. what is the non-OF code block that is simpler if it
doesn't have to worry about CONFIG_OF?

g.

> ---
>  include/linux/of_platform.h |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/linux/of_platform.h b/include/linux/of_platform.h
> index b47d204..d8f587f 100644
> --- a/include/linux/of_platform.h
> +++ b/include/linux/of_platform.h
> @@ -96,6 +96,13 @@ extern int of_platform_populate(struct device_node *root,
>  				struct device *parent);
>  #endif /* CONFIG_OF_ADDRESS */
>  
> +#else  /* CONFIG_OF_DEVICE */
> +static inline struct platform_device *of_find_device_by_node(
> +					struct device_node *np)
> +{
> +	return NULL;
> +}
> +
>  #endif /* CONFIG_OF_DEVICE */
>  
>  #if !defined(CONFIG_OF_ADDRESS)
> -- 
> 1.7.9.5
>
diff mbox

Patch

diff --git a/include/linux/of_platform.h b/include/linux/of_platform.h
index b47d204..d8f587f 100644
--- a/include/linux/of_platform.h
+++ b/include/linux/of_platform.h
@@ -96,6 +96,13 @@  extern int of_platform_populate(struct device_node *root,
 				struct device *parent);
 #endif /* CONFIG_OF_ADDRESS */
 
+#else  /* CONFIG_OF_DEVICE */
+static inline struct platform_device *of_find_device_by_node(
+					struct device_node *np)
+{
+	return NULL;
+}
+
 #endif /* CONFIG_OF_DEVICE */
 
 #if !defined(CONFIG_OF_ADDRESS)