From patchwork Wed Jan 2 11:53:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 1923101 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id B9E2CDF215 for ; Wed, 2 Jan 2013 11:54:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752644Ab3ABLyZ (ORCPT ); Wed, 2 Jan 2013 06:54:25 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:50609 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752090Ab3ABLyZ (ORCPT ); Wed, 2 Jan 2013 06:54:25 -0500 Received: by mail-pa0-f42.google.com with SMTP id rl6so7993725pac.29 for ; Wed, 02 Jan 2013 03:54:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=W65qaSwJwOW6wSXzAfT+17Z3XDiTQgzHU39fpAnf4yc=; b=ifgrbJMn3bNCRPCzsjaL4HtqMDENdP5ENacRaTlbur/gRObXFmKmSzU1k1qHuCgtlL VjNsaJUhxWAv0R1jqvpUU1iIhDktLyxeomYyglC1CkV0rVGdG/+XX3iRjCehbXNDoqpr kxwytISqwkVLa8n0YknvIhkQAd0f4a9kmow0m7uajUU77DONy3zIBx7VrcLWWYc0lq5W l6xmLdXDh7JQM4rQHCrq2iwd86Dj9LLt+uEtu0xh/1MXMCw5UpwRyvdG++8oawCD7ljf F9i8rEHvm0vDz6ehPPConsO/DlMkVfeAaNhwwQO1i0L6slaAAdyQm/vy1FVbQpgTHKxQ pJ1Q== X-Received: by 10.69.0.8 with SMTP id au8mr144230480pbd.58.1357127664490; Wed, 02 Jan 2013 03:54:24 -0800 (PST) Received: from localhost.localdomain ([122.166.13.141]) by mx.google.com with ESMTPS id wr4sm28323107pbc.72.2013.01.02.03.54.20 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 02 Jan 2013 03:54:23 -0800 (PST) From: "Lad, Prabhakar" To: LMML Cc: LKML , Mauro Carvalho Chehab , DLOS , "Lad, Prabhakar" Subject: [PATCH] davinci: dm644x: fix enum ccdc_gama_width and enum ccdc_data_size comparision warning Date: Wed, 2 Jan 2013 17:23:50 +0530 Message-Id: <1357127630-8167-2-git-send-email-prabhakar.lad@ti.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1357127630-8167-1-git-send-email-prabhakar.lad@ti.com> References: <1357127630-8167-1-git-send-email-prabhakar.lad@ti.com> MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org while the effect is harmless this patch fixes following build warning, drivers/media/platform/davinci/dm644x_ccdc.c: In function ‘validate_ccdc_param’: drivers/media/platform/davinci/dm644x_ccdc.c:233:32: warning: comparison between ‘enum ccdc_gama_width’ and ‘enum ccdc_data_size’ [-Wenum-compare] Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/dm644x_ccdc.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/davinci/dm644x_ccdc.c b/drivers/media/platform/davinci/dm644x_ccdc.c index ee7942b..42b473a 100644 --- a/drivers/media/platform/davinci/dm644x_ccdc.c +++ b/drivers/media/platform/davinci/dm644x_ccdc.c @@ -228,9 +228,12 @@ static void ccdc_readregs(void) static int validate_ccdc_param(struct ccdc_config_params_raw *ccdcparam) { if (ccdcparam->alaw.enable) { + u32 gama_wd = ccdcparam->alaw.gama_wd; + u32 data_sz = ccdcparam->data_sz; + if ((ccdcparam->alaw.gama_wd > CCDC_GAMMA_BITS_09_0) || (ccdcparam->alaw.gama_wd < CCDC_GAMMA_BITS_15_6) || - (ccdcparam->alaw.gama_wd < ccdcparam->data_sz)) { + (gama_wd < data_sz)) { dev_dbg(ccdc_cfg.dev, "\nInvalid data line select"); return -1; }