From patchwork Thu Jan 3 13:22:40 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 1927691 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 340473FC33 for ; Thu, 3 Jan 2013 13:23:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753059Ab3ACNXy (ORCPT ); Thu, 3 Jan 2013 08:23:54 -0500 Received: from mail-pb0-f43.google.com ([209.85.160.43]:57487 "EHLO mail-pb0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752524Ab3ACNXx (ORCPT ); Thu, 3 Jan 2013 08:23:53 -0500 Received: by mail-pb0-f43.google.com with SMTP id um15so8494569pbc.2 for ; Thu, 03 Jan 2013 05:23:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=P7lBzrir3xSPgIqMCepUgpjgzRX8AlJ1Wo0m3kPtltc=; b=UBrpvg7xY4DMxvYLdLUhuvncWZ+GB6qxT2rX9kSj9LrlzSwOf46XeKEpDFjcbE2w8y qAwquuAdhw/S+IoYMofKhT468QKMtfas0Irslh+ImG0wbLiWNs3v4LT2Z/es9ccoc5Le yIGbT2UMVwD8LAgTxfsInECvcGE46pNUggI5WM3SbQKtR1N1xgDI2e3xoqAbVd/DeCRo aKvGHjwJAlUixx8cMTqZlpjS1XTecKfkZpASMVUTBT6XP96D3M+IO5dtYxGDRm+HJtol Y6A8/RQZsbtvD72U6OGu3/e/6sQbSbVO5OEp9aNjVgoc6+pGrNDLoyXRD8sVB04eh2Dl LZDA== X-Received: by 10.66.85.103 with SMTP id g7mr145652991paz.45.1357219433478; Thu, 03 Jan 2013 05:23:53 -0800 (PST) Received: from localhost.localdomain ([122.166.13.141]) by mx.google.com with ESMTPS id ix9sm30343226pbc.7.2013.01.03.05.23.49 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 Jan 2013 05:23:52 -0800 (PST) From: "Lad, Prabhakar" To: LMML Cc: LKML , Mauro Carvalho Chehab , DLOS , Hans Verkuil , "Lad, Prabhakar" , Manjunath Hadli Subject: [PATCH] ths7303: use devm_kzalloc() instead of kzalloc() Date: Thu, 3 Jan 2013 18:52:40 +0530 Message-Id: <1357219362-9080-2-git-send-email-prabhakar.lad@ti.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1357219362-9080-1-git-send-email-prabhakar.lad@ti.com> References: <1357219362-9080-1-git-send-email-prabhakar.lad@ti.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org I2C drivers can use devm_kzalloc() too in their .probe() methods. Doing so simplifies their clean up paths. Signed-off-by: Lad, Prabhakar Signed-off-by: Manjunath Hadli --- drivers/media/i2c/ths7303.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/ths7303.c b/drivers/media/i2c/ths7303.c index c31cc04..e747524 100644 --- a/drivers/media/i2c/ths7303.c +++ b/drivers/media/i2c/ths7303.c @@ -175,7 +175,7 @@ static int ths7303_probe(struct i2c_client *client, v4l_info(client, "chip found @ 0x%x (%s)\n", client->addr << 1, client->adapter->name); - sd = kzalloc(sizeof(struct v4l2_subdev), GFP_KERNEL); + sd = devm_kzalloc(&client->dev, sizeof(struct v4l2_subdev), GFP_KERNEL); if (sd == NULL) return -ENOMEM; @@ -189,7 +189,6 @@ static int ths7303_remove(struct i2c_client *client) struct v4l2_subdev *sd = i2c_get_clientdata(client); v4l2_device_unregister_subdev(sd); - kfree(sd); return 0; }