From patchwork Thu Jan 3 15:45:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sylwester Nawrocki/Kernel \\(PLT\\) /SRPOL/Staff Engineer/Samsung Electronics" X-Patchwork-Id: 1928251 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 809EADF25A for ; Thu, 3 Jan 2013 15:45:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753423Ab3ACPpY (ORCPT ); Thu, 3 Jan 2013 10:45:24 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:17528 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753419Ab3ACPpY (ORCPT ); Thu, 3 Jan 2013 10:45:24 -0500 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MG2008YN3RCGY30@mailout4.samsung.com> for linux-media@vger.kernel.org; Fri, 04 Jan 2013 00:45:23 +0900 (KST) X-AuditID: cbfee61b-b7f616d00000319b-45-50e5a79241fa Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 22.C2.12699.297A5E05; Fri, 04 Jan 2013 00:45:23 +0900 (KST) Received: from amdc1344.digital.local ([106.116.147.32]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MG2002B73RD7GA0@mmp2.samsung.com> for linux-media@vger.kernel.org; Fri, 04 Jan 2013 00:45:22 +0900 (KST) From: Sylwester Nawrocki To: linux-media@vger.kernel.org Cc: Sylwester Nawrocki , Kyungmin Park Subject: [PATCH 2/5] s5p-fimc: Prevent potential buffer overflow Date: Thu, 03 Jan 2013 16:45:07 +0100 Message-id: <1357227910-28870-2-git-send-email-s.nawrocki@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1357227910-28870-1-git-send-email-s.nawrocki@samsung.com> References: <1357227910-28870-1-git-send-email-s.nawrocki@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAJMWRmVeSWpSXmKPExsVy+t9jQd3Jy58GGCxdxGLRs2ErqwOjx+dN cgGMUVw2Kak5mWWpRfp2CVwZV08/ZCqYw1Vx6YZtA+Nhji5GTg4JAROJOX9vMkHYYhIX7q1n 62Lk4hASmM4ocWP+ImYIZwWTxKe/H9hBqtgEDCV6j/YxgtgiAvIST3pvsIHYzAIxEt9+XgKL Cws4SNz6eZQZxGYRUJVYN38nC4jNK+AmseR6A2sXIwfQNgWJOZNsQMKcAu4SF6/uACsRAiqZ dOUm4wRG3gWMDKsYRVMLkguKk9JzjfSKE3OLS/PS9ZLzczcxgv39THoH46oGi0OMAhyMSjy8 jPVPAoRYE8uKK3MPMUpwMCuJ8M7OfxogxJuSWFmVWpQfX1Sak1p8iFGag0VJnJfxFFC1QHpi SWp2ampBahFMlomDU6qBUbObbd7cn5wb3p3Iqdg7+bAsv3SQ7Yv6z+tFn821dmE5mxcpazf3 fOLmawp7Ooq7dk6RZJZXCQxYnK1Qlp3GIqs630w8R9rubNFSlil8pg8v6R8/fHLjt9KSMuZ1 yXL8P85pnn2aZX94+bGtFdde351QdojR2bj6TpjmAYfPs3bOeZqWcMTTRomlOCPRUIu5qDgR ADCKG1TzAQAA Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Replace the hard coded csi_sensors[] array size with a relevant constant to make sure we don't iterate beyond the actual array. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p-fimc/fimc-mdevice.c b/drivers/media/platform/s5p-fimc/fimc-mdevice.c index 8b43f98..e77dba7 100644 --- a/drivers/media/platform/s5p-fimc/fimc-mdevice.c +++ b/drivers/media/platform/s5p-fimc/fimc-mdevice.c @@ -627,7 +627,7 @@ static int __fimc_md_create_flite_source_links(struct fimc_md *fmd) */ static int fimc_md_create_links(struct fimc_md *fmd) { - struct v4l2_subdev *csi_sensors[2] = { NULL }; + struct v4l2_subdev *csi_sensors[CSIS_MAX_ENTITIES] = { NULL }; struct v4l2_subdev *sensor, *csis; struct s5p_fimc_isp_info *pdata; struct fimc_sensor_info *s_info; @@ -692,7 +692,7 @@ static int fimc_md_create_links(struct fimc_md *fmd) pad, link_mask); } - for (i = 0; i < ARRAY_SIZE(fmd->csis); i++) { + for (i = 0; i < CSIS_MAX_ENTITIES; i++) { if (fmd->csis[i].sd == NULL) continue; source = &fmd->csis[i].sd->entity;