From patchwork Thu Jan 3 15:45:09 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sylwester Nawrocki/Kernel \\(PLT\\) /SRPOL/Staff Engineer/Samsung Electronics" X-Patchwork-Id: 1928271 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 6F95C3FC33 for ; Thu, 3 Jan 2013 15:45:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753443Ab3ACPp3 (ORCPT ); Thu, 3 Jan 2013 10:45:29 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:49174 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753426Ab3ACPp2 (ORCPT ); Thu, 3 Jan 2013 10:45:28 -0500 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MG2001EF3RJLA20@mailout1.samsung.com> for linux-media@vger.kernel.org; Fri, 04 Jan 2013 00:45:26 +0900 (KST) X-AuditID: cbfee61a-b7fa66d0000004cf-a6-50e5a79685eb Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 5C.7F.01231.697A5E05; Fri, 04 Jan 2013 00:45:26 +0900 (KST) Received: from amdc1344.digital.local ([106.116.147.32]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MG2002B73RD7GA0@mmp2.samsung.com> for linux-media@vger.kernel.org; Fri, 04 Jan 2013 00:45:26 +0900 (KST) From: Sylwester Nawrocki To: linux-media@vger.kernel.org Cc: Tony Prisk , Sylwester Nawrocki Subject: [PATCH 4/5] s5p-fimc: Fix incorrect usage of IS_ERR_OR_NULL Date: Thu, 03 Jan 2013 16:45:09 +0100 Message-id: <1357227910-28870-4-git-send-email-s.nawrocki@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1357227910-28870-1-git-send-email-s.nawrocki@samsung.com> References: <1357227910-28870-1-git-send-email-s.nawrocki@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAJMWRmVeSWpSXmKPExsVy+t9jQd1py58GGOyfrWrRs2ErqwOjx+dN cgGMUVw2Kak5mWWpRfp2CVwZM9Z9YivYx15xZsVrlgbGVWxdjJwcEgImEj87ZjJD2GISF+6t B4pzcQgJTGeUOL5+LhOEs4JJ4vvyo+wgVWwChhK9R/sYQWwRAXmJJ703wCYxC4RK9G07y9rF yMEhLOAi8WuZJUiYRUBV4ublPWDlvAJuEn9nTGQGKZEQUJCYM8kGJMwp4C5x8eoOFhBbCKhk 0pWbjBMYeRcwMqxiFE0tSC4oTkrPNdQrTswtLs1L10vOz93ECPb3M6kdjCsbLA4xCnAwKvHw MtY/CRBiTSwrrsw9xCjBwawkwjs7/2mAEG9KYmVValF+fFFpTmrxIUZpDhYlcV7GU0DVAumJ JanZqakFqUUwWSYOTqkGRrlj1cfnTdoclBpro1noaHehNIvbwCijbUoi6+feJ+e/8TtoSJuy SArYyEa/1f3w+32R/9nFJres+6V6u3Z37DAPur3Rwe4Ca1CU/kyvK1wH4s4sXZUY9O9fnl3m r8YtG9KKdi/+ISiaee5IhAvD24O3P6ktLhWuO7fuueOLnV3v5P/1Ox3wV2Ipzkg01GIuKk4E ANkSW2LzAQAA Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Tony Prisk Replace IS_ERR_OR_NULL with IS_ERR on clk_get results. Signed-off-by: Tony Prisk Signed-off-by: Sylwester Nawrocki --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-fimc/fimc-mdevice.c b/drivers/media/platform/s5p-fimc/fimc-mdevice.c index 41ddfee..c243220 100644 --- a/drivers/media/platform/s5p-fimc/fimc-mdevice.c +++ b/drivers/media/platform/s5p-fimc/fimc-mdevice.c @@ -732,7 +732,7 @@ static int fimc_md_get_clocks(struct fimc_md *fmd) for (i = 0; i < FIMC_MAX_CAMCLKS; i++) { snprintf(clk_name, sizeof(clk_name), "sclk_cam%u", i); clock = clk_get(NULL, clk_name); - if (IS_ERR_OR_NULL(clock)) { + if (IS_ERR(clock)) { v4l2_err(&fmd->v4l2_dev, "Failed to get clock: %s", clk_name); return -ENXIO;