diff mbox

omap3isp: Don't include <plat/cpu.h>

Message ID 1357248204-9863-1-git-send-email-laurent.pinchart@ideasonboard.com (mailing list archive)
State New, archived
Headers show

Commit Message

Laurent Pinchart Jan. 3, 2013, 9:23 p.m. UTC
The plat/*.h headers are not available to drivers in multiplatform
kernels. As the header isn't needed, just remove it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/media/platform/omap3isp/isp.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

Comments

Tony Lindgren Jan. 3, 2013, 10:55 p.m. UTC | #1
* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [130103 13:24]:
> The plat/*.h headers are not available to drivers in multiplatform
> kernels. As the header isn't needed, just remove it.

Please consider merging this for the -rc cycle, so I can make
plat/cpu.h produce an error for omap2+ to prevent new drivers
including it.

Acked-by: Tony Lindgren <tony@atomide.com>
 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  drivers/media/platform/omap3isp/isp.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c
> index 50cea08..07eea5b 100644
> --- a/drivers/media/platform/omap3isp/isp.c
> +++ b/drivers/media/platform/omap3isp/isp.c
> @@ -71,8 +71,6 @@
>  #include <media/v4l2-common.h>
>  #include <media/v4l2-device.h>
>  
> -#include <plat/cpu.h>
> -
>  #include "isp.h"
>  #include "ispreg.h"
>  #include "ispccdc.h"
> -- 
> Regards,
> 
> Laurent Pinchart
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sakari Ailus Jan. 4, 2013, 11:06 p.m. UTC | #2
On Thu, Jan 03, 2013 at 10:23:24PM +0100, Laurent Pinchart wrote:
> The plat/*.h headers are not available to drivers in multiplatform
> kernels. As the header isn't needed, just remove it.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Acked-by: Sakari Ailus <sakari.ailus@iki.fi>
Mauro Carvalho Chehab Jan. 6, 2013, 1:10 p.m. UTC | #3
Em Thu, 3 Jan 2013 14:55:41 -0800
Tony Lindgren <tony@atomide.com> escreveu:

> * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [130103 13:24]:
> > The plat/*.h headers are not available to drivers in multiplatform
> > kernels. As the header isn't needed, just remove it.
> 
> Please consider merging this for the -rc cycle, so I can make
> plat/cpu.h produce an error for omap2+ to prevent new drivers
> including it.

Ok, I'll add it to the list of patches for 3.8.

Regards,
Mauro
> 
> Acked-by: Tony Lindgren <tony@atomide.com>
>  
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> >  drivers/media/platform/omap3isp/isp.c |    2 --
> >  1 files changed, 0 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c
> > index 50cea08..07eea5b 100644
> > --- a/drivers/media/platform/omap3isp/isp.c
> > +++ b/drivers/media/platform/omap3isp/isp.c
> > @@ -71,8 +71,6 @@
> >  #include <media/v4l2-common.h>
> >  #include <media/v4l2-device.h>
> >  
> > -#include <plat/cpu.h>
> > -
> >  #include "isp.h"
> >  #include "ispreg.h"
> >  #include "ispccdc.h"
> > -- 
> > Regards,
> > 
> > Laurent Pinchart
> > 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Laurent Pinchart Jan. 7, 2013, 1:14 a.m. UTC | #4
Hi Mauro,

On Sunday 06 January 2013 11:10:39 Mauro Carvalho Chehab wrote:
> Em Thu, 3 Jan 2013 14:55:41 -0800 Tony Lindgren escreveu:
> > * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [130103 13:24]:
> > > The plat/*.h headers are not available to drivers in multiplatform
> > > kernels. As the header isn't needed, just remove it.
> > 
> > Please consider merging this for the -rc cycle, so I can make
> > plat/cpu.h produce an error for omap2+ to prevent new drivers
> > including it.
> 
> Ok, I'll add it to the list of patches for 3.8.

Thank you.

Could you please also add "omap3isp: Don't include deleted OMAP plat/ header 
files" to that list ? And Sakari, could you please ack it ?

> > Acked-by: Tony Lindgren <tony@atomide.com>
> > 
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > ---
> > > 
> > >  drivers/media/platform/omap3isp/isp.c |    2 --
> > >  1 files changed, 0 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/media/platform/omap3isp/isp.c
> > > b/drivers/media/platform/omap3isp/isp.c index 50cea08..07eea5b 100644
> > > --- a/drivers/media/platform/omap3isp/isp.c
> > > +++ b/drivers/media/platform/omap3isp/isp.c
> > > @@ -71,8 +71,6 @@
> > > 
> > >  #include <media/v4l2-common.h>
> > >  #include <media/v4l2-device.h>
> > > 
> > > -#include <plat/cpu.h>
> > > -
> > > 
> > >  #include "isp.h"
> > >  #include "ispreg.h"
> > >  #include "ispccdc.h"
diff mbox

Patch

diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c
index 50cea08..07eea5b 100644
--- a/drivers/media/platform/omap3isp/isp.c
+++ b/drivers/media/platform/omap3isp/isp.c
@@ -71,8 +71,6 @@ 
 #include <media/v4l2-common.h>
 #include <media/v4l2-device.h>
 
-#include <plat/cpu.h>
-
 #include "isp.h"
 #include "ispreg.h"
 #include "ispccdc.h"