| Message ID | 1358788568-11137-10-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jan 21, 2013 at 05:16:02PM +0000, Arnd Bergmann wrote: > The coda video codec driver depends on a mach-imx or mach-mxs specific > header file "mach/iram.h". This is not available when building for > multiplatform, so let us disable this driver for v3.8 when building > multiplatform, and hopefully find a proper fix for v3.9. > > drivers/media/platform/coda.c:27:23: fatal error: mach/iram.h: No such file or directory > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: Javier Martin <javier.martin@vista-silicon.com> > Cc: Fabio Estevam <fabio.estevam@freescale.com> > Cc: Sascha Hauer <kernel@pengutronix.de> > Cc: Shawn Guo <shawn.guo@linaro.org> Acked-by: Shawn Guo <shawn.guo@linaro.org> > Cc: Mauro Carvalho Chehab <mchehab@redhat.com> > Cc: linux-media@vger.kernel.org > --- > drivers/media/platform/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > index 3dcfea6..049d2b2 100644 > --- a/drivers/media/platform/Kconfig > +++ b/drivers/media/platform/Kconfig > @@ -142,7 +142,7 @@ if V4L_MEM2MEM_DRIVERS > > config VIDEO_CODA > tristate "Chips&Media Coda multi-standard codec IP" > - depends on VIDEO_DEV && VIDEO_V4L2 && ARCH_MXC > + depends on VIDEO_DEV && VIDEO_V4L2 && ARCH_MXC && !ARCH_MULTIPLATFORM > select VIDEOBUF2_DMA_CONTIG > select V4L2_MEM2MEM_DEV > select IRAM_ALLOC if SOC_IMX53 > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jan 21, 2013 at 05:16:02PM +0000, Arnd Bergmann wrote: > The coda video codec driver depends on a mach-imx or mach-mxs specific > header file "mach/iram.h". This is not available when building for > multiplatform, so let us disable this driver for v3.8 when building > multiplatform, and hopefully find a proper fix for v3.9. > > drivers/media/platform/coda.c:27:23: fatal error: mach/iram.h: No such file or directory I just sent a pull request for this with a proper fix. > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > index 3dcfea6..049d2b2 100644 > --- a/drivers/media/platform/Kconfig > +++ b/drivers/media/platform/Kconfig > @@ -142,7 +142,7 @@ if V4L_MEM2MEM_DRIVERS > > config VIDEO_CODA > tristate "Chips&Media Coda multi-standard codec IP" > - depends on VIDEO_DEV && VIDEO_V4L2 && ARCH_MXC > + depends on VIDEO_DEV && VIDEO_V4L2 && ARCH_MXC && !ARCH_MULTIPLATFORM This breakage is not multiplatform related at all, it won't compile without multiplatform support either. So depends on BROKEN would be more appropriate if you want to go this way. Sascha
Em Tue, 22 Jan 2013 11:54:04 +0800 Shawn Guo <shawn.guo@linaro.org> escreveu: > On Mon, Jan 21, 2013 at 05:16:02PM +0000, Arnd Bergmann wrote: > > The coda video codec driver depends on a mach-imx or mach-mxs specific > > header file "mach/iram.h". This is not available when building for > > multiplatform, so let us disable this driver for v3.8 when building > > multiplatform, and hopefully find a proper fix for v3.9. > > > > drivers/media/platform/coda.c:27:23: fatal error: mach/iram.h: No such file or directory > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Cc: Javier Martin <javier.martin@vista-silicon.com> > > Cc: Fabio Estevam <fabio.estevam@freescale.com> > > Cc: Sascha Hauer <kernel@pengutronix.de> > > Cc: Shawn Guo <shawn.guo@linaro.org> > > Acked-by: Shawn Guo <shawn.guo@linaro.org> > > > Cc: Mauro Carvalho Chehab <mchehab@redhat.com> Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com> > > Cc: linux-media@vger.kernel.org > > --- > > drivers/media/platform/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > > index 3dcfea6..049d2b2 100644 > > --- a/drivers/media/platform/Kconfig > > +++ b/drivers/media/platform/Kconfig > > @@ -142,7 +142,7 @@ if V4L_MEM2MEM_DRIVERS > > > > config VIDEO_CODA > > tristate "Chips&Media Coda multi-standard codec IP" > > - depends on VIDEO_DEV && VIDEO_V4L2 && ARCH_MXC > > + depends on VIDEO_DEV && VIDEO_V4L2 && ARCH_MXC && !ARCH_MULTIPLATFORM > > select VIDEOBUF2_DMA_CONTIG > > select V4L2_MEM2MEM_DEV > > select IRAM_ALLOC if SOC_IMX53 > > -- > > 1.7.10.4 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ >
Em Tue, 22 Jan 2013 10:32:22 -0200 Mauro Carvalho Chehab <mchehab@redhat.com> escreveu: > Em Tue, 22 Jan 2013 11:54:04 +0800 > Shawn Guo <shawn.guo@linaro.org> escreveu: > > > On Mon, Jan 21, 2013 at 05:16:02PM +0000, Arnd Bergmann wrote: > > > The coda video codec driver depends on a mach-imx or mach-mxs specific > > > header file "mach/iram.h". This is not available when building for > > > multiplatform, so let us disable this driver for v3.8 when building > > > multiplatform, and hopefully find a proper fix for v3.9. > > > > > > drivers/media/platform/coda.c:27:23: fatal error: mach/iram.h: No such file or directory > > > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > > Cc: Javier Martin <javier.martin@vista-silicon.com> > > > Cc: Fabio Estevam <fabio.estevam@freescale.com> > > > Cc: Sascha Hauer <kernel@pengutronix.de> > > > Cc: Shawn Guo <shawn.guo@linaro.org> > > > > Acked-by: Shawn Guo <shawn.guo@linaro.org> > > > > > Cc: Mauro Carvalho Chehab <mchehab@redhat.com> > > Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com> Err... actually, as Sascha has a proper fix for it, it should be used, instead. So: Nacked-by: Mauro Carvalho Chehab <mchehab@redhat.com> Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday 22 January 2013, Sascha Hauer wrote: > On Mon, Jan 21, 2013 at 05:16:02PM +0000, Arnd Bergmann wrote: > > The coda video codec driver depends on a mach-imx or mach-mxs specific > > header file "mach/iram.h". This is not available when building for > > multiplatform, so let us disable this driver for v3.8 when building > > multiplatform, and hopefully find a proper fix for v3.9. > > > > drivers/media/platform/coda.c:27:23: fatal error: mach/iram.h: No such file or directory > > I just sent a pull request for this with a proper fix. Ok, even better. Thanks for taking care of it! Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index 3dcfea6..049d2b2 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -142,7 +142,7 @@ if V4L_MEM2MEM_DRIVERS config VIDEO_CODA tristate "Chips&Media Coda multi-standard codec IP" - depends on VIDEO_DEV && VIDEO_V4L2 && ARCH_MXC + depends on VIDEO_DEV && VIDEO_V4L2 && ARCH_MXC && !ARCH_MULTIPLATFORM select VIDEOBUF2_DMA_CONTIG select V4L2_MEM2MEM_DEV select IRAM_ALLOC if SOC_IMX53
The coda video codec driver depends on a mach-imx or mach-mxs specific header file "mach/iram.h". This is not available when building for multiplatform, so let us disable this driver for v3.8 when building multiplatform, and hopefully find a proper fix for v3.9. drivers/media/platform/coda.c:27:23: fatal error: mach/iram.h: No such file or directory Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Javier Martin <javier.martin@vista-silicon.com> Cc: Fabio Estevam <fabio.estevam@freescale.com> Cc: Sascha Hauer <kernel@pengutronix.de> Cc: Shawn Guo <shawn.guo@linaro.org> Cc: Mauro Carvalho Chehab <mchehab@redhat.com> Cc: linux-media@vger.kernel.org --- drivers/media/platform/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)