diff mbox

[1/3,v2] v4l: Define video buffer flag for the COPY timestamp type

Message ID 1359030907-9883-2-git-send-email-k.debski@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kamil Debski Jan. 24, 2013, 12:35 p.m. UTC
Define video buffer flag for the COPY timestamp. In this case the timestamp
value is copied from the OUTPUT to the corresponding CAPTURE buffer.

Signed-off-by: Kamil Debski <k.debski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 Documentation/DocBook/media/v4l/io.xml |    6 ++++++
 include/uapi/linux/videodev2.h         |    1 +
 2 files changed, 7 insertions(+)

Comments

Hans Verkuil Jan. 24, 2013, 12:51 p.m. UTC | #1
On Thu 24 January 2013 13:35:05 Kamil Debski wrote:
> Define video buffer flag for the COPY timestamp. In this case the timestamp
> value is copied from the OUTPUT to the corresponding CAPTURE buffer.
> 
> Signed-off-by: Kamil Debski <k.debski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  Documentation/DocBook/media/v4l/io.xml |    6 ++++++
>  include/uapi/linux/videodev2.h         |    1 +
>  2 files changed, 7 insertions(+)
> 
> diff --git a/Documentation/DocBook/media/v4l/io.xml b/Documentation/DocBook/media/v4l/io.xml
> index 73f202f..fdd1822 100644
> --- a/Documentation/DocBook/media/v4l/io.xml
> +++ b/Documentation/DocBook/media/v4l/io.xml
> @@ -1145,6 +1145,12 @@ in which case caches have not been used.</entry>
>  	    same clock outside V4L2, use
>  	    <function>clock_gettime(2)</function> .</entry>
>  	  </row>
> +	  <row>
> +	    <entry><constant>V4L2_BUF_FLAG_TIMESTAMP_COPY</constant></entry>
> +	    <entry>0x4000</entry>
> +	    <entry>The CAPTURE buffer timestamp has been taken from the
> +	    corresponding OUTPUT buffer.</entry>
> +	  </row>

I think I mentioned it before somewhere, but it is helpful if it is mentioned
here that this only applies to mem2mem devices.

Regards,

	Hans

>  	</tbody>
>        </tgroup>
>      </table>
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 72e9921..d5a59af 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -697,6 +697,7 @@ struct v4l2_buffer {
>  #define V4L2_BUF_FLAG_TIMESTAMP_MASK		0xe000
>  #define V4L2_BUF_FLAG_TIMESTAMP_UNKNOWN		0x0000
>  #define V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC	0x2000
> +#define V4L2_BUF_FLAG_TIMESTAMP_COPY		0x4000
>  
>  /**
>   * struct v4l2_exportbuffer - export of video buffer as DMABUF file descriptor
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kamil Debski Jan. 24, 2013, 3:25 p.m. UTC | #2
Hi,

> From: Hans Verkuil [mailto:hverkuil@xs4all.nl]
> Sent: Thursday, January 24, 2013 1:51 PM
> 
> On Thu 24 January 2013 13:35:05 Kamil Debski wrote:
> > Define video buffer flag for the COPY timestamp. In this case the
> > timestamp value is copied from the OUTPUT to the corresponding
> CAPTURE buffer.
> >
> > Signed-off-by: Kamil Debski <k.debski@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> >  Documentation/DocBook/media/v4l/io.xml |    6 ++++++
> >  include/uapi/linux/videodev2.h         |    1 +
> >  2 files changed, 7 insertions(+)
> >
> > diff --git a/Documentation/DocBook/media/v4l/io.xml
> > b/Documentation/DocBook/media/v4l/io.xml
> > index 73f202f..fdd1822 100644
> > --- a/Documentation/DocBook/media/v4l/io.xml
> > +++ b/Documentation/DocBook/media/v4l/io.xml
> > @@ -1145,6 +1145,12 @@ in which case caches have not been
> used.</entry>
> >  	    same clock outside V4L2, use
> >  	    <function>clock_gettime(2)</function> .</entry>
> >  	  </row>
> > +	  <row>
> > +
> <entry><constant>V4L2_BUF_FLAG_TIMESTAMP_COPY</constant></entry>
> > +	    <entry>0x4000</entry>
> > +	    <entry>The CAPTURE buffer timestamp has been taken from the
> > +	    corresponding OUTPUT buffer.</entry>
> > +	  </row>
> 
> I think I mentioned it before somewhere, but it is helpful if it is
> mentioned here that this only applies to mem2mem devices.

Ok, will do.

Best wishes,
Kamil
 
> Regards,
> 
> 	Hans
> 
> >  	</tbody>
> >        </tgroup>
> >      </table>
> > diff --git a/include/uapi/linux/videodev2.h
> > b/include/uapi/linux/videodev2.h index 72e9921..d5a59af 100644
> > --- a/include/uapi/linux/videodev2.h
> > +++ b/include/uapi/linux/videodev2.h
> > @@ -697,6 +697,7 @@ struct v4l2_buffer {
> >  #define V4L2_BUF_FLAG_TIMESTAMP_MASK		0xe000
> >  #define V4L2_BUF_FLAG_TIMESTAMP_UNKNOWN		0x0000
> >  #define V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC	0x2000
> > +#define V4L2_BUF_FLAG_TIMESTAMP_COPY		0x4000
> >
> >  /**
> >   * struct v4l2_exportbuffer - export of video buffer as DMABUF file
> > descriptor
> >


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/DocBook/media/v4l/io.xml b/Documentation/DocBook/media/v4l/io.xml
index 73f202f..fdd1822 100644
--- a/Documentation/DocBook/media/v4l/io.xml
+++ b/Documentation/DocBook/media/v4l/io.xml
@@ -1145,6 +1145,12 @@  in which case caches have not been used.</entry>
 	    same clock outside V4L2, use
 	    <function>clock_gettime(2)</function> .</entry>
 	  </row>
+	  <row>
+	    <entry><constant>V4L2_BUF_FLAG_TIMESTAMP_COPY</constant></entry>
+	    <entry>0x4000</entry>
+	    <entry>The CAPTURE buffer timestamp has been taken from the
+	    corresponding OUTPUT buffer.</entry>
+	  </row>
 	</tbody>
       </tgroup>
     </table>
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index 72e9921..d5a59af 100644
--- a/include/uapi/linux/videodev2.h
+++ b/include/uapi/linux/videodev2.h
@@ -697,6 +697,7 @@  struct v4l2_buffer {
 #define V4L2_BUF_FLAG_TIMESTAMP_MASK		0xe000
 #define V4L2_BUF_FLAG_TIMESTAMP_UNKNOWN		0x0000
 #define V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC	0x2000
+#define V4L2_BUF_FLAG_TIMESTAMP_COPY		0x4000
 
 /**
  * struct v4l2_exportbuffer - export of video buffer as DMABUF file descriptor