| Message ID | 1362570838-4737-5-git-send-email-shaik.ameer@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: Please don't leave the change log empty. I'll apply this patch. I'm just wondering, if there aren't any further changes needed to make the driver really working on exynos5250 ? > Signed-off-by: Shaik Ameer Basha<shaik.ameer@samsung.com> > --- > drivers/media/platform/s5p-fimc/mipi-csis.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/s5p-fimc/mipi-csis.c b/drivers/media/platform/s5p-fimc/mipi-csis.c > index df4411c..debda7c 100644 > --- a/drivers/media/platform/s5p-fimc/mipi-csis.c > +++ b/drivers/media/platform/s5p-fimc/mipi-csis.c > @@ -1002,6 +1002,7 @@ static const struct dev_pm_ops s5pcsis_pm_ops = { > static const struct of_device_id s5pcsis_of_match[] __devinitconst = { > { .compatible = "samsung,exynos3110-csis" }, > { .compatible = "samsung,exynos4210-csis" }, > + { .compatible = "samsung,exynos5250-csis" }, > { /* sentinel */ }, > }; > MODULE_DEVICE_TABLE(of, s5pcsis_of_match); -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sylwester, On Mon, Mar 11, 2013 at 2:10 AM, Sylwester Nawrocki <sylvester.nawrocki@gmail.com> wrote: > On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: > > Please don't leave the change log empty. I'll apply this patch. > I'm just wondering, if there aren't any further changes needed > to make the driver really working on exynos5250 ? > There was nothing from driver side to change for making it work for Exynos5250. May be I need to update the S5P_INTMASK_EN_ALL to include all interrupts. Regards, Shaik Ameer Basha > >> Signed-off-by: Shaik Ameer Basha<shaik.ameer@samsung.com> >> --- >> drivers/media/platform/s5p-fimc/mipi-csis.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/media/platform/s5p-fimc/mipi-csis.c >> b/drivers/media/platform/s5p-fimc/mipi-csis.c >> index df4411c..debda7c 100644 >> --- a/drivers/media/platform/s5p-fimc/mipi-csis.c >> +++ b/drivers/media/platform/s5p-fimc/mipi-csis.c >> @@ -1002,6 +1002,7 @@ static const struct dev_pm_ops s5pcsis_pm_ops = { >> static const struct of_device_id s5pcsis_of_match[] __devinitconst = { >> { .compatible = "samsung,exynos3110-csis" }, >> { .compatible = "samsung,exynos4210-csis" }, >> + { .compatible = "samsung,exynos5250-csis" }, >> { /* sentinel */ }, >> }; >> MODULE_DEVICE_TABLE(of, s5pcsis_of_match); -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Shaik, On 03/11/2013 07:58 AM, Shaik Ameer Basha wrote: > Hi Sylwester, > > On Mon, Mar 11, 2013 at 2:10 AM, Sylwester Nawrocki > <sylvester.nawrocki@gmail.com> wrote: >> On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: >> >> Please don't leave the change log empty. I'll apply this patch. >> I'm just wondering, if there aren't any further changes needed >> to make the driver really working on exynos5250 ? >> > > There was nothing from driver side to change for making it work > for Exynos5250. May be I need to update the S5P_INTMASK_EN_ALL > to include all interrupts. Yes, it might be a good idea squash that change into this patch, i.e. the last patch form Arun's exynos5 fimc-is series. BTW, I'll try to find a time to review the fimc-is patches this week. Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/s5p-fimc/mipi-csis.c b/drivers/media/platform/s5p-fimc/mipi-csis.c index df4411c..debda7c 100644 --- a/drivers/media/platform/s5p-fimc/mipi-csis.c +++ b/drivers/media/platform/s5p-fimc/mipi-csis.c @@ -1002,6 +1002,7 @@ static const struct dev_pm_ops s5pcsis_pm_ops = { static const struct of_device_id s5pcsis_of_match[] __devinitconst = { { .compatible = "samsung,exynos3110-csis" }, { .compatible = "samsung,exynos4210-csis" }, + { .compatible = "samsung,exynos5250-csis" }, { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, s5pcsis_of_match);
Signed-off-by: Shaik Ameer Basha <shaik.ameer@samsung.com> --- drivers/media/platform/s5p-fimc/mipi-csis.c | 1 + 1 file changed, 1 insertion(+)