diff mbox

[v12,2/2] drm/exynos: enable OF_VIDEOMODE and FB_MODE_HELPERS for exynos drm fimd

Message ID 1362641984-2706-3-git-send-email-vikas.sajjan@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Vikas C Sajjan March 7, 2013, 7:39 a.m. UTC
patch adds "select OF_VIDEOMODE" and "select FB_MODE_HELPERS" when
EXYNOS_DRM_FIMD config is selected.

Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
 drivers/gpu/drm/exynos/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

Comments

Inki Dae March 7, 2013, 8:04 a.m. UTC | #1
> -----Original Message-----
> From: linux-media-owner@vger.kernel.org [mailto:linux-media-
> owner@vger.kernel.org] On Behalf Of Vikas Sajjan
> Sent: Thursday, March 07, 2013 4:40 PM
> To: dri-devel@lists.freedesktop.org
> Cc: linux-media@vger.kernel.org; kgene.kim@samsung.com;
> inki.dae@samsung.com; l.krishna@samsung.com; joshi@samsung.com; linaro-
> kernel@lists.linaro.org
> Subject: [PATCH v12 2/2] drm/exynos: enable OF_VIDEOMODE and
> FB_MODE_HELPERS for exynos drm fimd
> 
> patch adds "select OF_VIDEOMODE" and "select FB_MODE_HELPERS" when
> EXYNOS_DRM_FIMD config is selected.
> 
> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> ---
>  drivers/gpu/drm/exynos/Kconfig |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/exynos/Kconfig
> b/drivers/gpu/drm/exynos/Kconfig
> index 046bcda..bb25130 100644
> --- a/drivers/gpu/drm/exynos/Kconfig
> +++ b/drivers/gpu/drm/exynos/Kconfig
> @@ -25,6 +25,8 @@ config DRM_EXYNOS_DMABUF
>  config DRM_EXYNOS_FIMD
>  	bool "Exynos DRM FIMD"
>  	depends on DRM_EXYNOS && !FB_S3C && !ARCH_MULTIPLATFORM

Again, you missed 'OF' dependency. At least, let's have build testing surely
before posting :)

Thanks,
Inki Dae

> +	select OF_VIDEOMODE
> +	select FB_MODE_HELPERS
>  	help
>  	  Choose this option if you want to use Exynos FIMD for DRM.
> 
> --
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Vikas C Sajjan March 7, 2013, 11:39 p.m. UTC | #2
Hi Mr. Dae,

On 7 March 2013 13:34, Inki Dae <inki.dae@samsung.com> wrote:
>
>
>> -----Original Message-----
>> From: linux-media-owner@vger.kernel.org [mailto:linux-media-
>> owner@vger.kernel.org] On Behalf Of Vikas Sajjan
>> Sent: Thursday, March 07, 2013 4:40 PM
>> To: dri-devel@lists.freedesktop.org
>> Cc: linux-media@vger.kernel.org; kgene.kim@samsung.com;
>> inki.dae@samsung.com; l.krishna@samsung.com; joshi@samsung.com; linaro-
>> kernel@lists.linaro.org
>> Subject: [PATCH v12 2/2] drm/exynos: enable OF_VIDEOMODE and
>> FB_MODE_HELPERS for exynos drm fimd
>>
>> patch adds "select OF_VIDEOMODE" and "select FB_MODE_HELPERS" when
>> EXYNOS_DRM_FIMD config is selected.
>>
>> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
>> ---
>>  drivers/gpu/drm/exynos/Kconfig |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/exynos/Kconfig
>> b/drivers/gpu/drm/exynos/Kconfig
>> index 046bcda..bb25130 100644
>> --- a/drivers/gpu/drm/exynos/Kconfig
>> +++ b/drivers/gpu/drm/exynos/Kconfig
>> @@ -25,6 +25,8 @@ config DRM_EXYNOS_DMABUF
>>  config DRM_EXYNOS_FIMD
>>       bool "Exynos DRM FIMD"
>>       depends on DRM_EXYNOS && !FB_S3C && !ARCH_MULTIPLATFORM
>
> Again, you missed 'OF' dependency. At least, let's have build testing surely
> before posting :)
>
 Surely will add " depends on OF && DRM_EXYNOS && !FB_S3C &&
!ARCH_MULTIPLATFORM "
and repost.

> Thanks,
> Inki Dae
>
>> +     select OF_VIDEOMODE
>> +     select FB_MODE_HELPERS
>>       help
>>         Choose this option if you want to use Exynos FIMD for DRM.
>>
>> --
>> 1.7.9.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
index 046bcda..bb25130 100644
--- a/drivers/gpu/drm/exynos/Kconfig
+++ b/drivers/gpu/drm/exynos/Kconfig
@@ -25,6 +25,8 @@  config DRM_EXYNOS_DMABUF
 config DRM_EXYNOS_FIMD
 	bool "Exynos DRM FIMD"
 	depends on DRM_EXYNOS && !FB_S3C && !ARCH_MULTIPLATFORM
+	select OF_VIDEOMODE
+	select FB_MODE_HELPERS
 	help
 	  Choose this option if you want to use Exynos FIMD for DRM.