From patchwork Sun Mar 10 01:42:35 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antti Palosaari X-Patchwork-Id: 2242841 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 6F65FDF2F2 for ; Sun, 10 Mar 2013 01:43:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751743Ab3CJBnq (ORCPT ); Sat, 9 Mar 2013 20:43:46 -0500 Received: from mail.kapsi.fi ([217.30.184.167]:35570 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751713Ab3CJBnq (ORCPT ); Sat, 9 Mar 2013 20:43:46 -0500 Received: from dyn3-82-128-191-178.psoas.suomi.net ([82.128.191.178] helo=localhost.localdomain) by mail.kapsi.fi with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1UEVIe-0000bM-6Z; Sun, 10 Mar 2013 03:43:44 +0200 From: Antti Palosaari To: linux-media@vger.kernel.org Cc: Antti Palosaari , Malcolm Priestley Subject: [REVIEW PATCH 5/5] it913x: fix pid filter Date: Sun, 10 Mar 2013 03:42:35 +0200 Message-Id: <1362879755-4839-5-git-send-email-crope@iki.fi> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1362879755-4839-1-git-send-email-crope@iki.fi> References: <1362879755-4839-1-git-send-email-crope@iki.fi> X-SA-Exim-Connect-IP: 82.128.191.178 X-SA-Exim-Mail-From: crope@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org I just made commit: "dvb_usb_v2: rework USB streaming logic" that breaks that driver PID filter. it913x driver checks use of PID filter directly from DVB USB v2 core internal variable "adap->pid_filtering" and stores it to own state. Calling order of .pid_filter_ctrl() and .pid_filter() was changed and due to that state was updated too late. Update state earlier. TODO: checking PID filter usage from DVB USB v2 is not very good idea as PID filter callbacks are called only when PID filter is enabled. Cc: Malcolm Priestley Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/it913x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/dvb-usb-v2/it913x.c b/drivers/media/usb/dvb-usb-v2/it913x.c index 8338479..e48cdeb 100644 --- a/drivers/media/usb/dvb-usb-v2/it913x.c +++ b/drivers/media/usb/dvb-usb-v2/it913x.c @@ -218,6 +218,7 @@ static int it913x_pid_filter_ctrl(struct dvb_usb_adapter *adap, int onoff) deb_info(1, "PID_C (%02x)", onoff); + st->pid_filter_onoff = adap->pid_filtering; ret = it913x_wr_reg(d, pro, PID_EN, st->pid_filter_onoff); mutex_unlock(&d->i2c_mutex);