From patchwork Mon Apr 22 14:03:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sylwester Nawrocki/Kernel \\(PLT\\) /SRPOL/Staff Engineer/Samsung Electronics" X-Patchwork-Id: 2472061 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 41E9C3FCA5 for ; Mon, 22 Apr 2013 14:06:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754222Ab3DVOGt (ORCPT ); Mon, 22 Apr 2013 10:06:49 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:63101 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752844Ab3DVOGs (ORCPT ); Mon, 22 Apr 2013 10:06:48 -0400 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MLN00CO9TUILVJ0@mailout2.samsung.com> for linux-media@vger.kernel.org; Mon, 22 Apr 2013 23:06:47 +0900 (KST) X-AuditID: cbfee61a-b7f156d000002a55-64-517543f76ffa Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 42.A7.10837.7F345715; Mon, 22 Apr 2013 23:06:47 +0900 (KST) Received: from amdc1344.digital.local ([106.116.147.32]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MLN004L3TQD2V50@mmp1.samsung.com>; Mon, 22 Apr 2013 23:06:47 +0900 (KST) From: Sylwester Nawrocki To: linux-media@vger.kernel.org Cc: kyungmin.park@samsung.com, sw0312.kim@samsung.com, a.hajda@samsung.com, Sylwester Nawrocki Subject: [PATCH 09/12] exynos4-is: Remove redundant module_put() for MIPI-CSIS module Date: Mon, 22 Apr 2013 16:03:44 +0200 Message-id: <1366639427-14253-10-git-send-email-s.nawrocki@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1366639427-14253-1-git-send-email-s.nawrocki@samsung.com> References: <1366639427-14253-1-git-send-email-s.nawrocki@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFJMWRmVeSWpSXmKPExsVy+t9jAd3vzqWBBnN7DS1urTvHanG26Q27 Rc+GrawWh9+0s1rMmPySzYHVo2/LKkaPz5vkApiiuGxSUnMyy1KL9O0SuDJ27bvBWjCDo2Lb 3T+sDYxN7F2MnBwSAiYSH1e+hLLFJC7cW8/WxcjFISSwiFHi0+O9TBBOB5PEr0UNjCBVbAKG Er1H+8BsEQF5iSe9N9hAbGaBSokNa58yg9jCAuESl+a8A5vKIqAqMeXkfLAaXgF3iWPHjrJ2 MXIAbVOQmDPJBiTMCRT+suQGK4gtJOAmsWnlDfYJjLwLGBlWMYqmFiQXFCel5xrqFSfmFpfm pesl5+duYgSHyDOpHYwrGywOMQpwMCrx8K40Kw0UYk0sK67MPcQowcGsJMJ793VJoBBvSmJl VWpRfnxRaU5q8SFGaQ4WJXHeA63WgUIC6YklqdmpqQWpRTBZJg5OqQbGyF6NqmexR75lywZY yi+KuCAwo5QveKt4vZ7PZJOAzjkfF671OnX6QExUlfenW8/O/Pv2bOeJ26Zc6464suz1fxI9 R1RrsdjmHROqpU7Nm/Sae2+ZeJCdmIbq/TkCz99Kh59WE4mxjyx4faFbcO4Z6+QHn5Z4C08q lpHcVVMS0fYi+1TDNYEqJZbijERDLeai4kQA1dSfjg0CAAA= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Currently there is unbalanced module_put() on the s5p-csis module which prevents it from being unloaded. The subdev's owner module has reference count decremented in v4l2_device_unregister_subdev() so just remove this erroneous call. Cc: stable@vger.kernel.org # 3.8 Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/media-dev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c index a371ee5..15ef8f2 100644 --- a/drivers/media/platform/exynos4-is/media-dev.c +++ b/drivers/media/platform/exynos4-is/media-dev.c @@ -814,7 +814,6 @@ static void fimc_md_unregister_entities(struct fimc_md *fmd) if (fmd->csis[i].sd == NULL) continue; v4l2_device_unregister_subdev(fmd->csis[i].sd); - module_put(fmd->csis[i].sd->owner); fmd->csis[i].sd = NULL; } for (i = 0; i < fmd->num_sensors; i++) {