From patchwork Tue May 14 05:45:16 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 2562941 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 04C6DDF24C for ; Tue, 14 May 2013 05:48:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752369Ab3ENFsB (ORCPT ); Tue, 14 May 2013 01:48:01 -0400 Received: from mail-pb0-f49.google.com ([209.85.160.49]:57329 "EHLO mail-pb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751588Ab3ENFsA (ORCPT ); Tue, 14 May 2013 01:48:00 -0400 Received: by mail-pb0-f49.google.com with SMTP id rp2so120778pbb.22 for ; Mon, 13 May 2013 22:48:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=An2N5Us6EnBxDjPyRg7gSqCsNdpdLcfSt9gOz+PnZtE=; b=nVngIwiUBJ0UcR+8Z8/PVmjAQKm0qG0+cFijoIUIsnVT6lWNcSY/gtm3zVk4NjyVVM TpIPEIYBAzY0F6E6EdMFBt5td9fanLr4sWwlDBm+z20MbC6KT0rMgmDpWXxdGts1NqH9 mBagkzNKh6ZnVpglxYVFy+BWBEdN2MmKg4bY9VU/UHBu5Gg4FxPedrQytK/VPs4hTBKt 9IiY8/MlzSojQs8DUG4c8cQHGnK5EogzxAAtZLH/RmUT9w4BGoGxf1Kj+zE/Of80PeY7 vay+gG88YbTm0ElaVtdWhDBJDT6B4qE1OAvh9RBVQPfPF/T5TldxvyTDIYpJy2ZcKfal 9ucg== X-Received: by 10.66.25.80 with SMTP id a16mr32682847pag.97.1368510479961; Mon, 13 May 2013 22:47:59 -0700 (PDT) Received: from localhost.localdomain ([59.98.240.128]) by mx.google.com with ESMTPSA id ya4sm16758033pbb.24.2013.05.13.22.47.51 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 13 May 2013 22:47:59 -0700 (PDT) From: Lad Prabhakar To: LMML , uclinux-dist-devel@blackfin.uclinux.org, ivtv-devel@ivtvdriver.org Cc: linux-kernel@vger.kernel.org, DLOS , Mauro Carvalho Chehab , Hans Verkuil , Scott Jiang , Jonathan Corbet , Andy Walls , Mike Isely , Devin Heitmueller , Guennadi Liakhovetski , Antti Palosaari , =?UTF-8?q?Jon=20Arne=20J=C3=B8rgensen?= , Andy Shevchenko , Laurent Pinchart , Alexey Klimov , Martin Bugge , Javier Martin , =?UTF-8?q?Frank=20Sch=C3=A4fer?= , Janne Grunau , "Lad, Prabhakar" Subject: [PATCH 3/4] media: usb: remove duplicate checks for EPERM in vidioc_g/s_register Date: Tue, 14 May 2013 11:15:16 +0530 Message-Id: <1368510317-4356-4-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1368510317-4356-1-git-send-email-prabhakar.csengg@gmail.com> References: <1368510317-4356-1-git-send-email-prabhakar.csengg@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Lad, Prabhakar This patch removes check for EPERM in vidioc_g/s_register as this check is already performed by core. Signed-off-by: Lad, Prabhakar --- drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c index e11267f..01d1c2d 100644 --- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c +++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c @@ -5173,8 +5173,6 @@ int pvr2_hdw_register_access(struct pvr2_hdw *hdw, int stat = 0; int okFl = 0; - if (!capable(CAP_SYS_ADMIN)) return -EPERM; - req.match = *match; req.reg = reg_id; if (setFl) req.val = *val_ptr;