From patchwork Tue May 14 06:47:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 2563211 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 00111DF24C for ; Tue, 14 May 2013 06:49:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755350Ab3ENGsC (ORCPT ); Tue, 14 May 2013 02:48:02 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:45702 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751034Ab3ENGr5 (ORCPT ); Tue, 14 May 2013 02:47:57 -0400 Received: by mail-pa0-f47.google.com with SMTP id kl13so238312pab.34 for ; Mon, 13 May 2013 23:47:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=gtd56FRZe0ILNSGq/WEXPqc9ck/pFOUyefe8GXT/6yU=; b=dS5dh0jLhFYaqHjw/vPg0KA68qnJ1KfbRowmUwqjirIkzM9LHm4ebjffDQ7iXIEttT XK4aZswcejSxEteggYuBQPALfW9afcl+Qewplm7+0A0IBRurI6wycjZwCYA9TBGFehU0 zOreiK/jwsTXOpPH5wqAuDODRD0wCJGcje0GY6/cDC/AwaGaEYJ02uN9J41HFmHSxcqc b8WUGmRXuQHNcx+fvWKvqpxeBcqaPIXqRtODVR/rPn8/qu/3WDBEKn1i/s6L+L8j31wv t3pq5twZ/wynvU9dUeotbD6Egeg5J7fSTUhrYgYFEEN+h24sTQMra82KWxh7McKRHMWG mIGA== X-Received: by 10.68.176.133 with SMTP id ci5mr32532914pbc.21.1368514076721; Mon, 13 May 2013 23:47:56 -0700 (PDT) Received: from localhost.localdomain ([59.98.240.128]) by mx.google.com with ESMTPSA id lq4sm12114995pab.19.2013.05.13.23.47.51 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 13 May 2013 23:47:55 -0700 (PDT) From: Lad Prabhakar To: LMML Cc: LKML , DLOS , "Lad, Prabhakar" , Guennadi Liakhovetski , Laurent Pinchart , Hans Verkuil , Sakari Ailus , Mauro Carvalho Chehab Subject: [PATCH RFC v3 1/4] media: i2c: adv7343: add support for asynchronous probing Date: Tue, 14 May 2013 12:17:33 +0530 Message-Id: <1368514056-28859-2-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1368514056-28859-1-git-send-email-prabhakar.csengg@gmail.com> References: <1368514056-28859-1-git-send-email-prabhakar.csengg@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Lad, Prabhakar Both synchronous and asynchronous adv7343 subdevice probing is supported by this patch. Signed-off-by: Lad, Prabhakar Cc: Guennadi Liakhovetski Cc: Laurent Pinchart Cc: Hans Verkuil Cc: Sakari Ailus Cc: Mauro Carvalho Chehab --- drivers/media/i2c/adv7343.c | 16 ++++++++++++---- 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/adv7343.c b/drivers/media/i2c/adv7343.c index 9fc2b98..469e262 100644 --- a/drivers/media/i2c/adv7343.c +++ b/drivers/media/i2c/adv7343.c @@ -27,6 +27,7 @@ #include #include +#include #include #include #include @@ -455,16 +456,22 @@ static int adv7343_probe(struct i2c_client *client, ADV7343_GAIN_DEF); state->sd.ctrl_handler = &state->hdl; if (state->hdl.error) { - int err = state->hdl.error; - - v4l2_ctrl_handler_free(&state->hdl); - return err; + err = state->hdl.error; + goto done; } v4l2_ctrl_handler_setup(&state->hdl); err = adv7343_initialize(&state->sd); if (err) + goto done; + + state->sd.dev = &client->dev; + err = v4l2_async_register_subdev(&state->sd); + +done: + if (err < 0) v4l2_ctrl_handler_free(&state->hdl); + return err; } @@ -473,6 +480,7 @@ static int adv7343_remove(struct i2c_client *client) struct v4l2_subdev *sd = i2c_get_clientdata(client); struct adv7343_state *state = to_state(sd); + v4l2_async_unregister_subdev(&state->sd); v4l2_device_unregister_subdev(sd); v4l2_ctrl_handler_free(&state->hdl);