From patchwork Sat May 25 16:36:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 2613631 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 45F79DF2A2 for ; Sat, 25 May 2013 16:38:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757270Ab3EYQib (ORCPT ); Sat, 25 May 2013 12:38:31 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:33557 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757142Ab3EYQi2 (ORCPT ); Sat, 25 May 2013 12:38:28 -0400 Received: by mail-pb0-f46.google.com with SMTP id rq2so5309292pbb.5 for ; Sat, 25 May 2013 09:38:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=AhUii//4YCcFcYPRCrLMJcvVgCLjl416y4rK90LJCp8=; b=FYOA/ttcADDP/y50DPEdXZVlzLQxG0pDQXEMMBkQaAGyBxUcbf5m4pL3+bntUxMF0o clFjThmbCPq1HcZiKLw8udUtntQrugiRP7kpjveO6rxosHZxLsbSPl5L83sInJ4h+Dh7 sWDRy8ZgYjtbtlfTkRujum0qYT68yxV68YFhWLyQ+XZebZv1Vm+pi2Nzj8j0e97ypqK7 /sOFOlXopaDWAF4zcU0jh/LN0rz3KYr1qxE5n68JEgOn3VDZZN+enM7WL3T+VH/82xVG ihqKgXTTRKHnt1sRYYdvUf9qQ1cuqbsZW4Kqv9cXGUoo339QiKn17/zR8/z3hbmrCYmQ j+/g== X-Received: by 10.66.121.169 with SMTP id ll9mr22984015pab.126.1369499908439; Sat, 25 May 2013 09:38:28 -0700 (PDT) Received: from localhost.localdomain ([112.79.40.180]) by mx.google.com with ESMTPSA id kv2sm21040398pbc.28.2013.05.25.09.38.18 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sat, 25 May 2013 09:38:27 -0700 (PDT) From: Prabhakar Lad To: Hans Verkuil , Mauro Carvalho Chehab , LMML , Laurent Pinchart Cc: DLOS , LKML , "Lad, Prabhakar" Subject: [PATCH v2 2/5] media: davinci: vpif: Convert to devm_* api Date: Sat, 25 May 2013 22:06:33 +0530 Message-Id: <1369499796-18762-3-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1369499796-18762-1-git-send-email-prabhakar.csengg@gmail.com> References: <1369499796-18762-1-git-send-email-prabhakar.csengg@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Lad, Prabhakar Use devm_ioremap_resource instead of reques_mem_region()/ioremap(). This ensures more consistent error values and simplifies error paths. Signed-off-by: Lad, Prabhakar Acked-by: Laurent Pinchart --- drivers/media/platform/davinci/vpif.c | 27 ++++----------------------- 1 files changed, 4 insertions(+), 23 deletions(-) diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c index 761c825..164c1b7 100644 --- a/drivers/media/platform/davinci/vpif.c +++ b/drivers/media/platform/davinci/vpif.c @@ -37,8 +37,6 @@ MODULE_LICENSE("GPL"); #define VPIF_CH2_MAX_MODES (15) #define VPIF_CH3_MAX_MODES (02) -static resource_size_t res_len; -static struct resource *res; spinlock_t vpif_lock; void __iomem *vpif_base; @@ -421,23 +419,12 @@ EXPORT_SYMBOL(vpif_channel_getfid); static int vpif_probe(struct platform_device *pdev) { - int status = 0; + static struct resource *res; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -ENOENT; - - res_len = resource_size(res); - - res = request_mem_region(res->start, res_len, res->name); - if (!res) - return -EBUSY; - - vpif_base = ioremap(res->start, res_len); - if (!vpif_base) { - status = -EBUSY; - goto fail; - } + vpif_base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(vpif_base)) + return PTR_ERR(vpif_base); pm_runtime_enable(&pdev->dev); pm_runtime_get(&pdev->dev); @@ -445,17 +432,11 @@ static int vpif_probe(struct platform_device *pdev) spin_lock_init(&vpif_lock); dev_info(&pdev->dev, "vpif probe success\n"); return 0; - -fail: - release_mem_region(res->start, res_len); - return status; } static int vpif_remove(struct platform_device *pdev) { pm_runtime_disable(&pdev->dev); - iounmap(vpif_base); - release_mem_region(res->start, res_len); return 0; }