From patchwork Sun May 26 12:00:12 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 2615101 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id C5DFE40E2C for ; Sun, 26 May 2013 12:03:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753100Ab3EZMDa (ORCPT ); Sun, 26 May 2013 08:03:30 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:49095 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752877Ab3EZMD2 (ORCPT ); Sun, 26 May 2013 08:03:28 -0400 Received: by mail-pa0-f42.google.com with SMTP id bj1so651213pad.1 for ; Sun, 26 May 2013 05:03:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=TiBUV5/olRh96ort2tJtF/qf9MQCH3/ka1kUd9w29Bg=; b=KljuIUY/6zm+eTN+P61l2P4b+/2SsRe243IW7Di2+cDXInd7GTa7AhFRWGNPlpTul3 VrlB7npBaIZHZ5lywNlTlEBnntGXqie+A3MmHgeUN0IhtBKfhad/EPRagqpHd9zuNyeJ U87XQ3zJGb8nOP/D3ZSHjX4/Ru5we6gSme0VD9w8b8wxyN3zlIDzxm9H6sW6H7AxtVc0 fLruKwHvj4oudTqG53UnvtLDTxTARsWCAuxeUJGqbH5XTsAmBYg8cShBxLReOVRvskzV UEo9w3v1WglKyHUPoetl7iEgZl3Sri3rDFNpO72L6e5V4GKBZfEuEXhDEr1P+aB8m+ri lE/w== X-Received: by 10.68.141.14 with SMTP id rk14mr25572763pbb.1.1369569808072; Sun, 26 May 2013 05:03:28 -0700 (PDT) Received: from localhost.localdomain ([112.79.41.196]) by mx.google.com with ESMTPSA id ri8sm24237417pbc.3.2013.05.26.05.03.20 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sun, 26 May 2013 05:03:27 -0700 (PDT) From: Prabhakar Lad To: Hans Verkuil , Mauro Carvalho Chehab , LMML , Laurent Pinchart Cc: DLOS , LKML , "Lad, Prabhakar" Subject: [PATCH v3 9/9] media: davinci: vpif_display: Convert to devm_* api Date: Sun, 26 May 2013 17:30:12 +0530 Message-Id: <1369569612-30915-10-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1369569612-30915-1-git-send-email-prabhakar.csengg@gmail.com> References: <1369569612-30915-1-git-send-email-prabhakar.csengg@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Lad, Prabhakar use devm_request_irq() instead of request_irq(). This ensures more consistent error values and simplifies error paths. Signed-off-by: Lad, Prabhakar Acked-by: Laurent Pinchart --- drivers/media/platform/davinci/vpif_display.c | 35 ++++++------------------ 1 files changed, 9 insertions(+), 26 deletions(-) diff --git a/drivers/media/platform/davinci/vpif_display.c b/drivers/media/platform/davinci/vpif_display.c index 7bcfe7d..e2f080b 100644 --- a/drivers/media/platform/davinci/vpif_display.c +++ b/drivers/media/platform/davinci/vpif_display.c @@ -1718,15 +1718,14 @@ static __init int vpif_probe(struct platform_device *pdev) while ((res = platform_get_resource(pdev, IORESOURCE_IRQ, res_idx))) { for (i = res->start; i <= res->end; i++) { - if (request_irq(i, vpif_channel_isr, IRQF_SHARED, - "VPIF_Display", (void *) - (&vpif_obj.dev[res_idx]->channel_id))) { - err = -EBUSY; - for (j = 0; j < i; j++) - free_irq(j, (void *) - (&vpif_obj.dev[res_idx]->channel_id)); + err = devm_request_irq(&pdev->dev, i, vpif_channel_isr, + IRQF_SHARED, "VPIF_Display", + (void *)(&vpif_obj.dev[res_idx]-> + channel_id)); + if (err) { + err = -EINVAL; vpif_err("VPIF IRQ request failed\n"); - goto vpif_int_err; + goto vpif_unregister; } } res_idx++; @@ -1744,7 +1743,7 @@ static __init int vpif_probe(struct platform_device *pdev) video_device_release(ch->video_dev); } err = -ENOMEM; - goto vpif_int_err; + goto vpif_unregister; } /* Initialize field of video device */ @@ -1878,13 +1877,8 @@ vpif_sd_error: /* Note: does nothing if ch->video_dev == NULL */ video_device_release(ch->video_dev); } -vpif_int_err: +vpif_unregister: v4l2_device_unregister(&vpif_obj.v4l2_dev); - for (i = 0; i < res_idx; i++) { - res = platform_get_resource(pdev, IORESOURCE_IRQ, i); - for (j = res->start; j <= res->end; j++) - free_irq(j, (void *)(&vpif_obj.dev[i]->channel_id)); - } return err; } @@ -1894,20 +1888,9 @@ vpif_int_err: */ static int vpif_remove(struct platform_device *device) { - struct platform_device *pdev; struct channel_obj *ch; - struct resource *res; - int irq_num; int i = 0; - pdev = container_of(vpif_dev, struct platform_device, dev); - while ((res = platform_get_resource(pdev, IORESOURCE_IRQ, i))) { - for (irq_num = res->start; irq_num <= res->end; irq_num++) - free_irq(irq_num, - (void *)(&vpif_obj.dev[i]->channel_id)); - i++; - } - v4l2_device_unregister(&vpif_obj.v4l2_dev); kfree(vpif_obj.sd);