| Message ID | 1379665927-18497-1-git-send-email-sachin.kamat@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 09/20/2013 10:32 AM, Sachin Kamat wrote: > module_pci_driver removes some boilerplate and makes code simpler. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> For this patch series: Acked-by: Hans Verkuil <hans.verkuil@cisco.com> Regards, Hans > --- > drivers/media/pci/cx88/cx88-alsa.c | 25 +------------------------ > 1 file changed, 1 insertion(+), 24 deletions(-) > > diff --git a/drivers/media/pci/cx88/cx88-alsa.c b/drivers/media/pci/cx88/cx88-alsa.c > index 05428bf..11d0692 100644 > --- a/drivers/media/pci/cx88/cx88-alsa.c > +++ b/drivers/media/pci/cx88/cx88-alsa.c > @@ -949,27 +949,4 @@ static struct pci_driver cx88_audio_pci_driver = { > .remove = cx88_audio_finidev, > }; > > -/**************************************************************************** > - LINUX MODULE INIT > - ****************************************************************************/ > - > -/* > - * module init > - */ > -static int __init cx88_audio_init(void) > -{ > - printk(KERN_INFO "cx2388x alsa driver version %s loaded\n", > - CX88_VERSION); > - return pci_register_driver(&cx88_audio_pci_driver); > -} > - > -/* > - * module remove > - */ > -static void __exit cx88_audio_fini(void) > -{ > - pci_unregister_driver(&cx88_audio_pci_driver); > -} > - > -module_init(cx88_audio_init); > -module_exit(cx88_audio_fini); > +module_pci_driver(cx88_audio_pci_driver); > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/pci/cx88/cx88-alsa.c b/drivers/media/pci/cx88/cx88-alsa.c index 05428bf..11d0692 100644 --- a/drivers/media/pci/cx88/cx88-alsa.c +++ b/drivers/media/pci/cx88/cx88-alsa.c @@ -949,27 +949,4 @@ static struct pci_driver cx88_audio_pci_driver = { .remove = cx88_audio_finidev, }; -/**************************************************************************** - LINUX MODULE INIT - ****************************************************************************/ - -/* - * module init - */ -static int __init cx88_audio_init(void) -{ - printk(KERN_INFO "cx2388x alsa driver version %s loaded\n", - CX88_VERSION); - return pci_register_driver(&cx88_audio_pci_driver); -} - -/* - * module remove - */ -static void __exit cx88_audio_fini(void) -{ - pci_unregister_driver(&cx88_audio_pci_driver); -} - -module_init(cx88_audio_init); -module_exit(cx88_audio_fini); +module_pci_driver(cx88_audio_pci_driver);
module_pci_driver removes some boilerplate and makes code simpler. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/media/pci/cx88/cx88-alsa.c | 25 +------------------------ 1 file changed, 1 insertion(+), 24 deletions(-)