From patchwork Sat Oct 19 17:09:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Walls X-Patchwork-Id: 3072451 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id EDABF9F288 for ; Sat, 19 Oct 2013 17:08:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0476820534 for ; Sat, 19 Oct 2013 17:08:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A418B203B5 for ; Sat, 19 Oct 2013 17:08:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753440Ab3JSRHx (ORCPT ); Sat, 19 Oct 2013 13:07:53 -0400 Received: from proofpoint-cluster.metrocast.net ([65.175.128.136]:46678 "EHLO proofpoint-cluster.metrocast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752120Ab3JSRHw (ORCPT ); Sat, 19 Oct 2013 13:07:52 -0400 Received: from [192.168.1.2] (d-24-153-52-48.cpe.metrocast.net [24.153.52.48]) (authenticated bits=0) by cherry.metrocast.net (8.13.8/8.13.8) with ESMTP id r9JH7n1m023335; Sat, 19 Oct 2013 17:07:49 GMT Message-ID: <1382202581.2405.5.camel@palomino.walls.org> Subject: Re: ivtv 1.4.2/1.4.3 broken in recent kernels? From: Andy Walls To: Rajil Saraswat Cc: linux-media@vger.kernel.org, Hans Verkuil Date: Sat, 19 Oct 2013 13:09:41 -0400 In-Reply-To: References: <1381371651.1889.21.camel@palomino.walls.org> <1381620192.22245.18.camel@palomino.walls.org> <1381668541.2209.14.camel@palomino.walls.org> <1381707800.1875.63.camel@palomino.walls.org> X-Mailer: Evolution 3.4.4 (3.4.4-2.fc17) Mime-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.10.8794, 1.0.431, 0.0.0000 definitions=2013-10-18_03:2013-10-18, 2013-10-18, 1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=6.0.2-1305240000 definitions=main-1310190081 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, 2013-10-16 at 01:10 +0100, Rajil Saraswat wrote: > I was finally able to carry out a git bisect. Had to do a git pull on > a fast internet hooked machine and ftp the files over to the remote > machine. > > I started with 'git bisect bad v2.6.36.4' and 'git bisect good v2.6.35.10'. > > And the result was: > > 5aa9ae5ed5d449a85fbf7aac3d1fdc241c542a79 is the first bad commit > commit 5aa9ae5ed5d449a85fbf7aac3d1fdc241c542a79 > Author: Hans Verkuil > Date: Sat Apr 24 08:23:53 2010 -0300 > > V4L/DVB: wm8775: convert to the new control framework > > Signed-off-by: Hans Verkuil > Signed-off-by: Mauro Carvalho Chehab > > :040000 040000 37847ffe592f255c6a9d9daedaf7bbfd3cd7b055 > 2f094df6f65d7fb296657619c1ad6f93fe085a75 M drivers > > I then removed the patch from linux-2.6.36-gentoo-r8 which are gentoo > sources, and confirmed that video/audio now works fine on v4l2-ctl -d > /dev/video1 --set-input 4 > > I wasnt able to remove the patch in 3.10.7 which is gentoo stable > kernel. Any idea how can i do that? Try applying the following (untested) patch that is made against the bleeding edge Linux kernel. The test on the mute control state in wm8775_s_routing() appears to have been inverted in the bad commit you isolated. Along with '--set-input', you may also want to use v4l2-ctl to exercise the mute control as well, to see if it works as expected, once this patch is applied. Regards, Andy file: wm8775_s_route_mute_test_inverted.patch Signed-off-by: Andy Walls Reported-by: Rajil Saraswat --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/i2c/wm8775.c b/drivers/media/i2c/wm8775.c index 3f584a7..bee7946 100644 --- a/drivers/media/i2c/wm8775.c +++ b/drivers/media/i2c/wm8775.c @@ -130,12 +130,10 @@ static int wm8775_s_routing(struct v4l2_subdev *sd, return -EINVAL; } state->input = input; - if (!v4l2_ctrl_g_ctrl(state->mute)) + if (v4l2_ctrl_g_ctrl(state->mute)) return 0; if (!v4l2_ctrl_g_ctrl(state->vol)) return 0; - if (!v4l2_ctrl_g_ctrl(state->bal)) - return 0; wm8775_set_audio(sd, 1); return 0; }