| Message ID | 1383748068-22182-1-git-send-email-ricardo.ribalda@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Ricardo, Thank you for the patch. On Wednesday 06 November 2013 15:27:48 Ricardo Ribalda Delgado wrote: > git grep shows that the function is only called from ths7303.c > > Fix this build warning: > > CC drivers/media/i2c/ths7303.o > drivers/media/i2c/ths7303.c:86:5: warning: no previous prototype for > ‘ths7303_setval’ [-Wmissing-prototypes] int ths7303_setval(struct > v4l2_subdev *sd, enum ths7303_filter_mode mode) ^ > > Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> > --- > drivers/media/i2c/ths7303.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/ths7303.c b/drivers/media/i2c/ths7303.c > index 42276d9..16da153 100644 > --- a/drivers/media/i2c/ths7303.c > +++ b/drivers/media/i2c/ths7303.c > @@ -83,7 +83,8 @@ static int ths7303_write(struct v4l2_subdev *sd, u8 reg, > u8 val) } > > /* following function is used to set ths7303 */ > -int ths7303_setval(struct v4l2_subdev *sd, enum ths7303_filter_mode mode) > +static int ths7303_setval(struct v4l2_subdev *sd, > + enum ths7303_filter_mode mode) If you align 'enum' on 'struct' from the line above, Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > { > struct i2c_client *client = v4l2_get_subdevdata(sd); > struct ths7303_state *state = to_state(sd);
Hello Laurent I have just uploaded a patch, please take a look if I align it properly. Thanks! On Wed, Nov 6, 2013 at 3:33 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > Hi Ricardo, > > Thank you for the patch. > > On Wednesday 06 November 2013 15:27:48 Ricardo Ribalda Delgado wrote: >> git grep shows that the function is only called from ths7303.c >> >> Fix this build warning: >> >> CC drivers/media/i2c/ths7303.o >> drivers/media/i2c/ths7303.c:86:5: warning: no previous prototype for >> ‘ths7303_setval’ [-Wmissing-prototypes] int ths7303_setval(struct >> v4l2_subdev *sd, enum ths7303_filter_mode mode) ^ >> >> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> >> --- >> drivers/media/i2c/ths7303.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/media/i2c/ths7303.c b/drivers/media/i2c/ths7303.c >> index 42276d9..16da153 100644 >> --- a/drivers/media/i2c/ths7303.c >> +++ b/drivers/media/i2c/ths7303.c >> @@ -83,7 +83,8 @@ static int ths7303_write(struct v4l2_subdev *sd, u8 reg, >> u8 val) } >> >> /* following function is used to set ths7303 */ >> -int ths7303_setval(struct v4l2_subdev *sd, enum ths7303_filter_mode mode) >> +static int ths7303_setval(struct v4l2_subdev *sd, >> + enum ths7303_filter_mode mode) > > If you align 'enum' on 'struct' from the line above, > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >> { >> struct i2c_client *client = v4l2_get_subdevdata(sd); >> struct ths7303_state *state = to_state(sd); > -- > Regards, > > Laurent Pinchart >
diff --git a/drivers/media/i2c/ths7303.c b/drivers/media/i2c/ths7303.c index 42276d9..16da153 100644 --- a/drivers/media/i2c/ths7303.c +++ b/drivers/media/i2c/ths7303.c @@ -83,7 +83,8 @@ static int ths7303_write(struct v4l2_subdev *sd, u8 reg, u8 val) } /* following function is used to set ths7303 */ -int ths7303_setval(struct v4l2_subdev *sd, enum ths7303_filter_mode mode) +static int ths7303_setval(struct v4l2_subdev *sd, + enum ths7303_filter_mode mode) { struct i2c_client *client = v4l2_get_subdevdata(sd); struct ths7303_state *state = to_state(sd);
git grep shows that the function is only called from ths7303.c Fix this build warning: CC drivers/media/i2c/ths7303.o drivers/media/i2c/ths7303.c:86:5: warning: no previous prototype for ‘ths7303_setval’ [-Wmissing-prototypes] int ths7303_setval(struct v4l2_subdev *sd, enum ths7303_filter_mode mode) ^ Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> --- drivers/media/i2c/ths7303.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)