| Message ID | 1385766094-29621-1-git-send-email-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2013/11/30 Laurent Pinchart <laurent.pinchart@ideasonboard.com>: > vs6624_read() is only called in the conditionally-compiled > vs6624_g_register() function. Make the former conditionally-compiled as > well to silence build warnings. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/i2c/vs6624.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/i2c/vs6624.c b/drivers/media/i2c/vs6624.c > index 25bdd93..23f4f65 100644 > --- a/drivers/media/i2c/vs6624.c > +++ b/drivers/media/i2c/vs6624.c > @@ -503,6 +503,7 @@ static inline struct v4l2_subdev *to_sd(struct v4l2_ctrl *ctrl) > return &container_of(ctrl->handler, struct vs6624, hdl)->sd; > } > > +#ifdef CONFIG_VIDEO_ADV_DEBUG > static int vs6624_read(struct v4l2_subdev *sd, u16 index) > { > struct i2c_client *client = v4l2_get_subdevdata(sd); > @@ -515,6 +516,7 @@ static int vs6624_read(struct v4l2_subdev *sd, u16 index) > > return buf[0]; > } > +#endif > > static int vs6624_write(struct v4l2_subdev *sd, u16 index, > u8 value) Acked-by: Scott Jiang <scott.jiang.linux@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/i2c/vs6624.c b/drivers/media/i2c/vs6624.c index 25bdd93..23f4f65 100644 --- a/drivers/media/i2c/vs6624.c +++ b/drivers/media/i2c/vs6624.c @@ -503,6 +503,7 @@ static inline struct v4l2_subdev *to_sd(struct v4l2_ctrl *ctrl) return &container_of(ctrl->handler, struct vs6624, hdl)->sd; } +#ifdef CONFIG_VIDEO_ADV_DEBUG static int vs6624_read(struct v4l2_subdev *sd, u16 index) { struct i2c_client *client = v4l2_get_subdevdata(sd); @@ -515,6 +516,7 @@ static int vs6624_read(struct v4l2_subdev *sd, u16 index) return buf[0]; } +#endif static int vs6624_write(struct v4l2_subdev *sd, u16 index, u8 value)
vs6624_read() is only called in the conditionally-compiled vs6624_g_register() function. Make the former conditionally-compiled as well to silence build warnings. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- drivers/media/i2c/vs6624.c | 2 ++ 1 file changed, 2 insertions(+)