From patchwork Wed Dec 4 00:56:25 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 3280281 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D591E9F377 for ; Wed, 4 Dec 2013 00:56:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 20ADE20461 for ; Wed, 4 Dec 2013 00:56:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5DF0620412 for ; Wed, 4 Dec 2013 00:56:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755780Ab3LDA4r (ORCPT ); Tue, 3 Dec 2013 19:56:47 -0500 Received: from perceval.ideasonboard.com ([95.142.166.194]:44099 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755908Ab3LDA4m (ORCPT ); Tue, 3 Dec 2013 19:56:42 -0500 Received: from avalon.ideasonboard.com (unknown [91.177.177.98]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EB839366B1 for ; Wed, 4 Dec 2013 01:55:41 +0100 (CET) From: Laurent Pinchart To: linux-media@vger.kernel.org Subject: [PATCH 25/25] v4l: omap4iss: resizer: Fix comment regarding bypass mode Date: Wed, 4 Dec 2013 01:56:25 +0100 Message-Id: <1386118585-12449-26-git-send-email-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1386118585-12449-1-git-send-email-laurent.pinchart@ideasonboard.com> References: <1386118585-12449-1-git-send-email-laurent.pinchart@ideasonboard.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The comment explaining the usage of the bypass bit is wrong, fix it. Signed-off-by: Laurent Pinchart --- drivers/staging/media/omap4iss/iss_resizer.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/omap4iss/iss_resizer.c b/drivers/staging/media/omap4iss/iss_resizer.c index c6225d8..ae831b8 100644 --- a/drivers/staging/media/omap4iss/iss_resizer.c +++ b/drivers/staging/media/omap4iss/iss_resizer.c @@ -190,7 +190,9 @@ static void resizer_configure(struct iss_resizer_device *resizer) informat = &resizer->formats[RESIZER_PAD_SINK]; outformat = &resizer->formats[RESIZER_PAD_SOURCE_MEM]; - /* Make sure we don't bypass the resizer */ + /* Disable pass-through more. Despite its name, the BYPASS bit controls + * pass-through mode, not bypass mode. + */ iss_reg_clr(iss, OMAP4_ISS_MEM_ISP_RESIZER, RSZ_SRC_FMT0, RSZ_SRC_FMT0_BYPASS);