From patchwork Fri Jan 17 09:22:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 3503071 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 404C79F2E9 for ; Fri, 17 Jan 2014 09:26:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6C6B220165 for ; Fri, 17 Jan 2014 09:26:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A7DC42015E for ; Fri, 17 Jan 2014 09:26:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752382AbaAQJXF (ORCPT ); Fri, 17 Jan 2014 04:23:05 -0500 Received: from mail-pd0-f178.google.com ([209.85.192.178]:52120 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752268AbaAQJXA (ORCPT ); Fri, 17 Jan 2014 04:23:00 -0500 Received: by mail-pd0-f178.google.com with SMTP id y13so3783420pdi.9 for ; Fri, 17 Jan 2014 01:22:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=cmUGaHKNuj7z8oMhK6AdaB8k9+SryAicS49iJgu7qfE=; b=JUY/JvZc4XS9z8qLjGACGmHk0C26hkDFDllf9T3FykEKjr18oPR5bAggBmvDM+OKJU MAPmG8nWED61HlppiXSJLyrrOezKprBKAHdMAe3ptpmecLmE0Kk9C34LHLuO8L+7xLcH I3piqLbgbIxNHM12sgK2aal5tQsqwbe2wjnc65k124gNU9QdE8lpiGdBZGOlPY6ynR4U 91Zo3b0XsHRxTNUD/P8ADKvsGjaaz+Gqnb+hz8HoGmcNQZjIWdvS2ASsMRiyJRc38kYU DPdiC/f9e7SNciOEIixhYpBZ360kWNZy9e4Pj2j51jBAz6zcqd27wfLgHxqIDk0vdE85 P1fQ== X-Received: by 10.68.196.164 with SMTP id in4mr959211pbc.128.1389950579886; Fri, 17 Jan 2014 01:22:59 -0800 (PST) Received: from tango-charlie.vayavyatech.com ([59.98.244.200]) by mx.google.com with ESMTPSA id q7sm21151378pbc.20.2014.01.17.01.22.55 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 17 Jan 2014 01:22:58 -0800 (PST) From: Prabhakar Lad To: Laurent Pinchart Cc: LMML , LKML , "Lad, Prabhakar" Subject: [PATCH] media: i2c: mt9v032: Check return value of clk_prepare_enable/clk_set_rate Date: Fri, 17 Jan 2014 14:52:47 +0530 Message-Id: <1389950567-32577-1-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: "Lad, Prabhakar" clk_set_rate(), clk_prepare_enable() functions can fail, so check the return values to avoid surprises. Signed-off-by: Lad, Prabhakar Acked-by: Laurent Pinchart --- drivers/media/i2c/mt9v032.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c/mt9v032.c index 36c504b..40172b8 100644 --- a/drivers/media/i2c/mt9v032.c +++ b/drivers/media/i2c/mt9v032.c @@ -317,8 +317,14 @@ static int mt9v032_power_on(struct mt9v032 *mt9v032) struct i2c_client *client = v4l2_get_subdevdata(&mt9v032->subdev); int ret; - clk_set_rate(mt9v032->clk, mt9v032->sysclk); - clk_prepare_enable(mt9v032->clk); + ret = clk_set_rate(mt9v032->clk, mt9v032->sysclk); + if (ret < 0) + return ret; + + ret = clk_prepare_enable(mt9v032->clk); + if (ret) + return ret; + udelay(1); /* Reset the chip and stop data read out */