| Message ID | 1390168117-2925-4-git-send-email-fschaefer.oss@googlemail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Em Sun, 19 Jan 2014 22:48:36 +0100 Frank Schäfer <fschaefer.oss@googlemail.com> escreveu: > Commit e63b009d6e "" changed the error codes i2c ACK errors from -ENODEV to -ENXIO. > But it also introduced a line that maps -ENXIO back to -ENODEV in case of empty i2c > messages, which makes no sense, because > 1.) an ACK error is an ACK error no matter what the i2c message content is > 2.) -ENXIO is perfectly suited for probing, too I don't agree with this patch. 0-byte messages are only usin during device probe. > 3.) we are loosing the ability to distinguish USB device disconnects Huh? > > Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com> > --- > drivers/media/usb/em28xx/em28xx-i2c.c | 1 - > 1 Datei geändert, 1 Zeile entfernt(-) > > diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c > index ba6433c..a26d7d4 100644 > --- a/drivers/media/usb/em28xx/em28xx-i2c.c > +++ b/drivers/media/usb/em28xx/em28xx-i2c.c > @@ -539,7 +539,6 @@ static int em28xx_i2c_xfer(struct i2c_adapter *i2c_adap, > if (rc == -ENXIO) { > if (i2c_debug > 1) > printk(KERN_CONT " no device\n"); > - rc = -ENODEV; > } else { > if (i2c_debug > 1) > printk(KERN_CONT " ERROR: %i\n", rc);
Am 04.02.2014 19:47, schrieb Mauro Carvalho Chehab: > Em Sun, 19 Jan 2014 22:48:36 +0100 > Frank Schäfer <fschaefer.oss@googlemail.com> escreveu: > >> Commit e63b009d6e "" changed the error codes i2c ACK errors from -ENODEV to -ENXIO. >> But it also introduced a line that maps -ENXIO back to -ENODEV in case of empty i2c >> messages, which makes no sense, because >> 1.) an ACK error is an ACK error no matter what the i2c message content is >> 2.) -ENXIO is perfectly suited for probing, too > I don't agree with this patch. 0-byte messages are only usin during device > probe. ??? The error handling is inconsistent for no good reason. The old code always returned -ENODEV. Then you came to the conclusion that -ENODEV isn't good and we both agreed that -ENXIO is appropriate. But then you decided to keep -ENODEV for 0-Byte messages only. Why ? According to the i2c error code description, -ENXIO and -ENODEV are both suited for probing. AFAICS there are zero reasons for returning different error codes in case of the same i2c ack error. So please, either -ENODEV or -ENXIO instead of such inconsistencies. >> 3.) we are loosing the ability to distinguish USB device disconnects > Huh? Maybe (like me) you didn't notice that before. This is probably the most cogent argument for changing -ENODEV to -ENXIO for i2c ack errors in case of USB devices. ;-) Regards, Frank >> Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com> >> --- >> drivers/media/usb/em28xx/em28xx-i2c.c | 1 - >> 1 Datei geändert, 1 Zeile entfernt(-) >> >> diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c >> index ba6433c..a26d7d4 100644 >> --- a/drivers/media/usb/em28xx/em28xx-i2c.c >> +++ b/drivers/media/usb/em28xx/em28xx-i2c.c >> @@ -539,7 +539,6 @@ static int em28xx_i2c_xfer(struct i2c_adapter *i2c_adap, >> if (rc == -ENXIO) { >> if (i2c_debug > 1) >> printk(KERN_CONT " no device\n"); >> - rc = -ENODEV; >> } else { >> if (i2c_debug > 1) >> printk(KERN_CONT " ERROR: %i\n", rc); -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 09.02.2014 20:34, Frank Schäfer wrote: > > Am 04.02.2014 19:47, schrieb Mauro Carvalho Chehab: >> Em Sun, 19 Jan 2014 22:48:36 +0100 >> Frank Schäfer <fschaefer.oss@googlemail.com> escreveu: >> >>> Commit e63b009d6e "" changed the error codes i2c ACK errors from -ENODEV to -ENXIO. >>> But it also introduced a line that maps -ENXIO back to -ENODEV in case of empty i2c >>> messages, which makes no sense, because >>> 1.) an ACK error is an ACK error no matter what the i2c message content is >>> 2.) -ENXIO is perfectly suited for probing, too >> I don't agree with this patch. 0-byte messages are only usin during device >> probe. > ??? > > The error handling is inconsistent for no good reason. > > The old code always returned -ENODEV. > Then you came to the conclusion that -ENODEV isn't good and we both > agreed that -ENXIO is appropriate. > But then you decided to keep -ENODEV for 0-Byte messages only. > Why ? > According to the i2c error code description, -ENXIO and -ENODEV are both > suited for probing. > AFAICS there are zero reasons for returning different error codes in > case of the same i2c ack error. > So please, either -ENODEV or -ENXIO instead of such inconsistencies. > >>> 3.) we are loosing the ability to distinguish USB device disconnects >> Huh? > Maybe (like me) you didn't notice that before. > This is probably the most cogent argument for changing -ENODEV to -ENXIO > for i2c ack errors in case of USB devices. ;-) I looked the I2C spec and there seems to be *not* restriction I2C message len, nor any mention zero len is not valid. If that is the case, adapter should just do the zero len xfer if requested and return success if it is success (slave answers). If adapter does not support zero len messages it should return EOPNOTSUPP according to kernel i2c fault codes document. I think em28xx supports, so that is not case here. I think Frank is correct. I2C spec is here: http://www.nxp.com/documents/user_manual/UM10204.pdf Hope this helps. regards Antti
diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c index ba6433c..a26d7d4 100644 --- a/drivers/media/usb/em28xx/em28xx-i2c.c +++ b/drivers/media/usb/em28xx/em28xx-i2c.c @@ -539,7 +539,6 @@ static int em28xx_i2c_xfer(struct i2c_adapter *i2c_adap, if (rc == -ENXIO) { if (i2c_debug > 1) printk(KERN_CONT " no device\n"); - rc = -ENODEV; } else { if (i2c_debug > 1) printk(KERN_CONT " ERROR: %i\n", rc);
Commit e63b009d6e "" changed the error codes i2c ACK errors from -ENODEV to -ENXIO. But it also introduced a line that maps -ENXIO back to -ENODEV in case of empty i2c messages, which makes no sense, because 1.) an ACK error is an ACK error no matter what the i2c message content is 2.) -ENXIO is perfectly suited for probing, too 3.) we are loosing the ability to distinguish USB device disconnects Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com> --- drivers/media/usb/em28xx/em28xx-i2c.c | 1 - 1 Datei geändert, 1 Zeile entfernt(-)