diff mbox

[media] v4l2-dv-timings: fix GTF calculation

Message ID 1390470000-9072-1-git-send-email-marbugge@cisco.com (mailing list archive)
State New, archived
Headers show

Commit Message

Martin Bugge Jan. 23, 2014, 9:40 a.m. UTC
Round off image width to nearest 8 (GTF_CELL_GRAN)

A source sending a GTF (Generalized Timing Formula) format have no means of
signalling image width. The assumed aspect ratio may result in an odd image
width but according to the standard image width should be in multiple of 8.

Cc: Mats Randgaard <matrandg@cisco.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Martin Bugge <marbugge@cisco.com>
---
 drivers/media/v4l2-core/v4l2-dv-timings.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Hans Verkuil (hansverk) Jan. 23, 2014, 10:56 a.m. UTC | #1
Reviewed-by: Hans Verkuil <hans.verkuil@cisco.com>

Regards,

	Hans

On 01/23/14 10:40, Martin Bugge wrote:
> Round off image width to nearest 8 (GTF_CELL_GRAN)
> 
> A source sending a GTF (Generalized Timing Formula) format have no means of
> signalling image width. The assumed aspect ratio may result in an odd image
> width but according to the standard image width should be in multiple of 8.
> 
> Cc: Mats Randgaard <matrandg@cisco.com>
> Cc: Hans Verkuil <hans.verkuil@cisco.com>
> Signed-off-by: Martin Bugge <marbugge@cisco.com>
> ---
>  drivers/media/v4l2-core/v4l2-dv-timings.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-dv-timings.c b/drivers/media/v4l2-core/v4l2-dv-timings.c
> index ee52b9f4..f7902fe 100644
> --- a/drivers/media/v4l2-core/v4l2-dv-timings.c
> +++ b/drivers/media/v4l2-core/v4l2-dv-timings.c
> @@ -515,6 +515,7 @@ bool v4l2_detect_gtf(unsigned frame_height,
>  		aspect.denominator = 9;
>  	}
>  	image_width = ((image_height * aspect.numerator) / aspect.denominator);
> +	image_width = (image_width + GTF_CELL_GRAN/2) & ~(GTF_CELL_GRAN - 1);
>  
>  	/* Horizontal */
>  	if (default_gtf)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/media/v4l2-core/v4l2-dv-timings.c b/drivers/media/v4l2-core/v4l2-dv-timings.c
index ee52b9f4..f7902fe 100644
--- a/drivers/media/v4l2-core/v4l2-dv-timings.c
+++ b/drivers/media/v4l2-core/v4l2-dv-timings.c
@@ -515,6 +515,7 @@  bool v4l2_detect_gtf(unsigned frame_height,
 		aspect.denominator = 9;
 	}
 	image_width = ((image_height * aspect.numerator) / aspect.denominator);
+	image_width = (image_width + GTF_CELL_GRAN/2) & ~(GTF_CELL_GRAN - 1);
 
 	/* Horizontal */
 	if (default_gtf)