| Message ID | 1391958577.25424.22.camel@x220 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Paul, Thank you for the patch. On Sunday 09 February 2014 16:09:37 Paul Bolle wrote: > Commit d632dfefd36f ("[media] v4l: omap4iss: Add support for OMAP4 > camera interface - Build system") added a Kconfig entry for > VIDEO_OMAP4_DEBUG. But nothing uses that symbol. > > This entry was apparently copied from a similar entry for "OMAP 3 > Camera debug messages". But a corresponding Makefile line is missing. > Besides, the debug code also depends on a mysterious ISS_ISR_DEBUG > macro. This Kconfig entry can be removed. What about adding the associated Makefile line instead to #define DEBUG when VIDEO_OMAP4_DEBUG is selected, as with the OMAP3 ISP driver ? > Someone familiar with the code might be able to say what to do with the > code depending on the DEBUG and ISS_ISR_DEBUG macros. ISS_ISR_DEBUG is expected to be set by manually modifying the source code, as it prints lots of messages in interrupt context. > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > Untested. > > drivers/staging/media/omap4iss/Kconfig | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/staging/media/omap4iss/Kconfig > b/drivers/staging/media/omap4iss/Kconfig index b9fe753..78b0fba 100644 > --- a/drivers/staging/media/omap4iss/Kconfig > +++ b/drivers/staging/media/omap4iss/Kconfig > @@ -4,9 +4,3 @@ config VIDEO_OMAP4 > select VIDEOBUF2_DMA_CONTIG > ---help--- > Driver for an OMAP 4 ISS controller. > - > -config VIDEO_OMAP4_DEBUG > - bool "OMAP 4 Camera debug messages" > - depends on VIDEO_OMAP4 > - ---help--- > - Enable debug messages on OMAP 4 ISS controller driver.
Laurent, On Mon, 2014-02-10 at 15:13 +0100, Laurent Pinchart wrote: > On Sunday 09 February 2014 16:09:37 Paul Bolle wrote: > > Commit d632dfefd36f ("[media] v4l: omap4iss: Add support for OMAP4 > > camera interface - Build system") added a Kconfig entry for > > VIDEO_OMAP4_DEBUG. But nothing uses that symbol. > > > > This entry was apparently copied from a similar entry for "OMAP 3 > > Camera debug messages". But a corresponding Makefile line is missing. > > Besides, the debug code also depends on a mysterious ISS_ISR_DEBUG > > macro. This Kconfig entry can be removed. > > What about adding the associated Makefile line instead to #define DEBUG when > VIDEO_OMAP4_DEBUG is selected, as with the OMAP3 ISP driver ? > > > Someone familiar with the code might be able to say what to do with the > > code depending on the DEBUG and ISS_ISR_DEBUG macros. > > ISS_ISR_DEBUG is expected to be set by manually modifying the source code, as > it prints lots of messages in interrupt context. Which renders the DEBUG macro pointless. Or does the code use some dev_dbg()-like magic, which is only triggered if the DEBUG macro is set? Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Paul, On Monday 10 February 2014 16:13:51 Paul Bolle wrote: > On Mon, 2014-02-10 at 15:13 +0100, Laurent Pinchart wrote: > > On Sunday 09 February 2014 16:09:37 Paul Bolle wrote: > > > Commit d632dfefd36f ("[media] v4l: omap4iss: Add support for OMAP4 > > > camera interface - Build system") added a Kconfig entry for > > > VIDEO_OMAP4_DEBUG. But nothing uses that symbol. > > > > > > This entry was apparently copied from a similar entry for "OMAP 3 > > > Camera debug messages". But a corresponding Makefile line is missing. > > > Besides, the debug code also depends on a mysterious ISS_ISR_DEBUG > > > macro. This Kconfig entry can be removed. > > > > What about adding the associated Makefile line instead to #define DEBUG > > when VIDEO_OMAP4_DEBUG is selected, as with the OMAP3 ISP driver ? > > > > > Someone familiar with the code might be able to say what to do with the > > > code depending on the DEBUG and ISS_ISR_DEBUG macros. > > > > ISS_ISR_DEBUG is expected to be set by manually modifying the source code, > > as it prints lots of messages in interrupt context. > > Which renders the DEBUG macro pointless. Or does the code use some > dev_dbg()-like magic, which is only triggered if the DEBUG macro is set? Yes, dev_dbg() is used.
diff --git a/drivers/staging/media/omap4iss/Kconfig b/drivers/staging/media/omap4iss/Kconfig index b9fe753..78b0fba 100644 --- a/drivers/staging/media/omap4iss/Kconfig +++ b/drivers/staging/media/omap4iss/Kconfig @@ -4,9 +4,3 @@ config VIDEO_OMAP4 select VIDEOBUF2_DMA_CONTIG ---help--- Driver for an OMAP 4 ISS controller. - -config VIDEO_OMAP4_DEBUG - bool "OMAP 4 Camera debug messages" - depends on VIDEO_OMAP4 - ---help--- - Enable debug messages on OMAP 4 ISS controller driver.
Commit d632dfefd36f ("[media] v4l: omap4iss: Add support for OMAP4 camera interface - Build system") added a Kconfig entry for VIDEO_OMAP4_DEBUG. But nothing uses that symbol. This entry was apparently copied from a similar entry for "OMAP 3 Camera debug messages". But a corresponding Makefile line is missing. Besides, the debug code also depends on a mysterious ISS_ISR_DEBUG macro. This Kconfig entry can be removed. Someone familiar with the code might be able to say what to do with the code depending on the DEBUG and ISS_ISR_DEBUG macros. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- Untested. drivers/staging/media/omap4iss/Kconfig | 6 ------ 1 file changed, 6 deletions(-)