| Message ID | 1392958114-4542-1-git-send-email-gshark.jeong@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 2014-02-21 at 13:48 +0900, Daniel Jeong wrote: > Same with v3 and v4. It seems you wrote changelog between v4 and v5 into commit messages. More over when you prepare patch series you forgot to use --thread for git format-patch command. Thus, I suggest you to write better commit messages and put changelog into cover letter (--cover-letter option to git format-patch, and then vi 0000-cover-letter). > > Signed-off-by: Daniel Jeong <gshark.jeong@gmail.com> > --- > include/uapi/linux/v4l2-controls.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h > index 2cbe605..1d662f6 100644 > --- a/include/uapi/linux/v4l2-controls.h > +++ b/include/uapi/linux/v4l2-controls.h > @@ -812,6 +812,9 @@ enum v4l2_flash_strobe_source { > #define V4L2_FLASH_FAULT_SHORT_CIRCUIT (1 << 3) > #define V4L2_FLASH_FAULT_OVER_CURRENT (1 << 4) > #define V4L2_FLASH_FAULT_INDICATOR (1 << 5) > +#define V4L2_FLASH_FAULT_UNDER_VOLTAGE (1 << 6) > +#define V4L2_FLASH_FAULT_INPUT_VOLTAGE (1 << 7) > +#define V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE (1 << 8) > > #define V4L2_CID_FLASH_CHARGE (V4L2_CID_FLASH_CLASS_BASE + 11) > #define V4L2_CID_FLASH_READY (V4L2_CID_FLASH_CLASS_BASE + 12)
diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h index 2cbe605..1d662f6 100644 --- a/include/uapi/linux/v4l2-controls.h +++ b/include/uapi/linux/v4l2-controls.h @@ -812,6 +812,9 @@ enum v4l2_flash_strobe_source { #define V4L2_FLASH_FAULT_SHORT_CIRCUIT (1 << 3) #define V4L2_FLASH_FAULT_OVER_CURRENT (1 << 4) #define V4L2_FLASH_FAULT_INDICATOR (1 << 5) +#define V4L2_FLASH_FAULT_UNDER_VOLTAGE (1 << 6) +#define V4L2_FLASH_FAULT_INPUT_VOLTAGE (1 << 7) +#define V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE (1 << 8) #define V4L2_CID_FLASH_CHARGE (V4L2_CID_FLASH_CLASS_BASE + 11) #define V4L2_CID_FLASH_READY (V4L2_CID_FLASH_CLASS_BASE + 12)
Same with v3 and v4. Signed-off-by: Daniel Jeong <gshark.jeong@gmail.com> --- include/uapi/linux/v4l2-controls.h | 3 +++ 1 file changed, 3 insertions(+)