diff mbox

v4l2-pci-skeleton: fix typo while retrieving the skel_buffer

Message ID 1395683489-25986-1-git-send-email-prabhakar.csengg@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Prabhakar March 24, 2014, 5:51 p.m. UTC 
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>

Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
 Documentation/video4linux/v4l2-pci-skeleton.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hans Verkuil April 2, 2014, 9:38 a.m. UTC | #1 
On 03/24/14 18:51, Lad, Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> ---
>  Documentation/video4linux/v4l2-pci-skeleton.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/video4linux/v4l2-pci-skeleton.c b/Documentation/video4linux/v4l2-pci-skeleton.c
> index 3a1c0d2..61a56f4 100644
> --- a/Documentation/video4linux/v4l2-pci-skeleton.c
> +++ b/Documentation/video4linux/v4l2-pci-skeleton.c
> @@ -87,7 +87,7 @@ struct skel_buffer {
>  
>  static inline struct skel_buffer *to_skel_buffer(struct vb2_buffer *vb2)
>  {
> -	return container_of(vb2, struct skel_buffer, vb);
> +	return container_of(vb2, struct skel_buffer, vb2);

Why is this a type? The vb2_buffer member in struct skel_buffer is called
'vb', so this should be correct.

Regards,

	Hans

>  }
>  
>  static const struct pci_device_id skeleton_pci_tbl[] = {
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Prabhakar April 2, 2014, 10:22 a.m. UTC | #2 
Hi Hans,

On Wed, Apr 2, 2014 at 3:08 PM, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> On 03/24/14 18:51, Lad, Prabhakar wrote:
>> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>>
>> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>> ---
>>  Documentation/video4linux/v4l2-pci-skeleton.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/video4linux/v4l2-pci-skeleton.c b/Documentation/video4linux/v4l2-pci-skeleton.c
>> index 3a1c0d2..61a56f4 100644
>> --- a/Documentation/video4linux/v4l2-pci-skeleton.c
>> +++ b/Documentation/video4linux/v4l2-pci-skeleton.c
>> @@ -87,7 +87,7 @@ struct skel_buffer {
>>
>>  static inline struct skel_buffer *to_skel_buffer(struct vb2_buffer *vb2)
>>  {
>> -     return container_of(vb2, struct skel_buffer, vb);
>> +     return container_of(vb2, struct skel_buffer, vb2);
>
> Why is this a type? The vb2_buffer member in struct skel_buffer is called
> 'vb', so this should be correct.
>
Oops may be I overlooked, sorry for the noise.

Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/video4linux/v4l2-pci-skeleton.c b/Documentation/video4linux/v4l2-pci-skeleton.c
index 3a1c0d2..61a56f4 100644
--- a/Documentation/video4linux/v4l2-pci-skeleton.c
+++ b/Documentation/video4linux/v4l2-pci-skeleton.c
@@ -87,7 +87,7 @@  struct skel_buffer {
 
 static inline struct skel_buffer *to_skel_buffer(struct vb2_buffer *vb2)
 {
-	return container_of(vb2, struct skel_buffer, vb);
+	return container_of(vb2, struct skel_buffer, vb2);
 }
 
 static const struct pci_device_id skeleton_pci_tbl[] = {