diff mbox

videobuf2-core: remove duplicated code

Message ID 1400665723-21695-1-git-send-email-victor.lambret.ext@parrot.com (mailing list archive)
State New, archived
Headers show

Commit Message

Victor Lambret May 21, 2014, 9:48 a.m. UTC 
Remove duplicated test of buffer presence at streamon

Signed-off-by: Victor Lambret <victor.lambret.ext@parrot.com>
---
 drivers/media/v4l2-core/videobuf2-core.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Marek Szyprowski May 21, 2014, 10:36 a.m. UTC | #1 
Hello,

On 2014-05-21 11:48, Victor Lambret wrote:
> Remove duplicated test of buffer presence at streamon
>
> Signed-off-by: Victor Lambret <victor.lambret.ext@parrot.com>

Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---
>   drivers/media/v4l2-core/videobuf2-core.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
> index f9059bb..b731b66 100644
> --- a/drivers/media/v4l2-core/videobuf2-core.c
> +++ b/drivers/media/v4l2-core/videobuf2-core.c
> @@ -2067,10 +2067,6 @@ static int vb2_internal_streamon(struct vb2_queue *q, enum v4l2_buf_type type)
>   		return -EINVAL;
>   	}
>   
> -	if (!q->num_buffers) {
> -		dprintk(1, "streamon: no buffers have been allocated\n");
> -		return -EINVAL;
> -	}
>   	if (q->num_buffers < q->min_buffers_needed) {
>   		dprintk(1, "streamon: need at least %u allocated buffers\n",
>   				q->min_buffers_needed);

Best regards
diff mbox

Patch

diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
index f9059bb..b731b66 100644
--- a/drivers/media/v4l2-core/videobuf2-core.c
+++ b/drivers/media/v4l2-core/videobuf2-core.c
@@ -2067,10 +2067,6 @@  static int vb2_internal_streamon(struct vb2_queue *q, enum v4l2_buf_type type)
 		return -EINVAL;
 	}
 
-	if (!q->num_buffers) {
-		dprintk(1, "streamon: no buffers have been allocated\n");
-		return -EINVAL;
-	}
 	if (q->num_buffers < q->min_buffers_needed) {
 		dprintk(1, "streamon: need at least %u allocated buffers\n",
 				q->min_buffers_needed);