From patchwork Wed Jun 4 18:46:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 4296491 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C94C49F326 for ; Wed, 4 Jun 2014 18:47:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F180E20212 for ; Wed, 4 Jun 2014 18:47:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E55632021A for ; Wed, 4 Jun 2014 18:47:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751737AbaFDSqo (ORCPT ); Wed, 4 Jun 2014 14:46:44 -0400 Received: from mail-yk0-f179.google.com ([209.85.160.179]:43249 "EHLO mail-yk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751722AbaFDSqn (ORCPT ); Wed, 4 Jun 2014 14:46:43 -0400 Received: by mail-yk0-f179.google.com with SMTP id 19so6419750ykq.10 for ; Wed, 04 Jun 2014 11:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=HYalJPEvKE60/c1CryR47BISrpuyDtNdORzIX9/o1G8=; b=XrGmszdvgrWEGa3s0ZybHgnYl0alB83JtRyEuPKw7RhxfRB4vg0m09tX0bL2W5s5lB cNC1UsdByQqU/0qaP7AFMa1desTheT+RU/JNZlRyN518D2aznY/aHY6AHu+l7TfFeI2x v6+ZQQgpo+KUn1rwP+WIvSW6NMV/A6zdU7Hqh3M4crcMDX14GxMLdLYLAVWTScFwhpIl LHOOUsNsTfSMd4di0ZdckoVCnsu2XqhaqC//f/X6KlL7eYoxEvh5+krnk9QTvBLUqlHA vyhPFX1z8Fv/ERJNNAUlIIEDmuOcPDSkJHsH8tl2gK/L9x5FpDrAhEfxndcNrfdc9IYa 3+nw== X-Received: by 10.236.126.174 with SMTP id b34mr75290124yhi.56.1401907602308; Wed, 04 Jun 2014 11:46:42 -0700 (PDT) Received: from localhost.localdomain ([177.194.47.191]) by mx.google.com with ESMTPSA id b67sm4968856yhc.16.2014.06.04.11.46.40 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 04 Jun 2014 11:46:41 -0700 (PDT) From: Fabio Estevam To: m.chehab@samsung.com Cc: p.zabel@pengutronix.de, linux-media@vger.kernel.org, Fabio Estevam Subject: [PATCH v2 1/2] [media] coda: Return the real error on platform_get_irq() Date: Wed, 4 Jun 2014 15:46:23 -0300 Message-Id: <1401907584-30218-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.8.3.2 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fabio Estevam No need to return a 'fake' return value on platform_get_irq() failure. Propagate the real error instead. Signed-off-by: Fabio Estevam Acked-by: Philipp Zabel --- Changes since v1: - None. Only rebased against latest tree drivers/media/platform/coda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c index b178379..32b3b6d 100644 --- a/drivers/media/platform/coda.c +++ b/drivers/media/platform/coda.c @@ -3229,7 +3229,7 @@ static int coda_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) { dev_err(&pdev->dev, "failed to get irq resource\n"); - return -ENOENT; + return irq; } if (devm_request_threaded_irq(&pdev->dev, irq, NULL, coda_irq_handler,