From patchwork Sat Jun 28 18:13:37 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Utkin X-Patchwork-Id: 4441191 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4ACF89F319 for ; Sat, 28 Jun 2014 18:14:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6DF2120279 for ; Sat, 28 Jun 2014 18:14:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68B2E20176 for ; Sat, 28 Jun 2014 18:14:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756147AbaF1SOG (ORCPT ); Sat, 28 Jun 2014 14:14:06 -0400 Received: from mail-lb0-f177.google.com ([209.85.217.177]:46188 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756099AbaF1SOE (ORCPT ); Sat, 28 Jun 2014 14:14:04 -0400 Received: by mail-lb0-f177.google.com with SMTP id u10so4876809lbd.36 for ; Sat, 28 Jun 2014 11:14:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=KPvzJ7GzHt9EHDkD6E/JBCoIBfvQ7iOvqWWIVvdSsQM=; b=X4FzjeLZ7c2ZX9lfB1YeSD2k3to/pHmUtFNLAd9rbsByfWjzco9LGndjaE2XtXinWa t1Qxaii3UW0GxyYDocrpamgviIPV30qXHNy2YDfyfhk4kmQXRYIZmTdOnsmbtW5xSctX XPjfgigS790aG9/WzTmh6bfqmlPngqGZsq21Un5SjDGr48T9PyGuk2jvhySq8BYAW2a/ W+PLGDWVYuIZkG4IWwDE+EHP/W/GFiGfgwV+VjpAvUuEhE3kY1a0WC+Xi6cMMviSc5CN z4Zj9d4bbP9xYzszDkSUWvSm/ghlUT3aOF660gqO6dqjvwOPwhEsNQAHT2udk+q0BFNd NjGA== X-Gm-Message-State: ALoCoQlY5aNs6IQwIIh4onEDTUE6F/MqTBkynOYtuXFjoBGos5fv+/0Wv8cBh+GZAQPp8QAlMNS7 X-Received: by 10.152.87.130 with SMTP id ay2mr22041363lab.18.1403979242083; Sat, 28 Jun 2014 11:14:02 -0700 (PDT) Received: from localhost.localdomain (alfa-g11.tenet.odessa.ua. [195.138.73.151]) by mx.google.com with ESMTPSA id ob4sm16339497lbc.30.2014.06.28.11.14.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Jun 2014 11:14:01 -0700 (PDT) From: Andrey Utkin To: linux-media@vger.kernel.org Cc: Andrey Utkin Subject: [PATCH] solo6x10: expose qp setting Date: Sat, 28 Jun 2014 21:13:37 +0300 Message-Id: <1403979218-4928-1-git-send-email-andrey.utkin@corp.bluecherry.net> X-Mailer: git-send-email 1.8.3.2 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello to all. In my opinion solo6x10 driver in upstream kernel gets less love than it deserves from us, and i hope to change that. I am a new employee developer in Bluecherry, unfortunately inexperienced in kernel field. I would be thankful a lot if I get some advices or even guidance to maintain this driver in a good way. With sending these trivial patches I hope to start a long-lasting cooperation to end up with nicely working driver having good reputation in mainline kernel. Also you can contact me for any issues related to solo6x10 cards. ---8<--- --- drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c b/drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c index b8ff113..bf6eb06 100644 --- a/drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c +++ b/drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c @@ -1111,6 +1111,9 @@ static int solo_s_ctrl(struct v4l2_ctrl *ctrl) case V4L2_CID_MPEG_VIDEO_GOP_SIZE: solo_enc->gop = ctrl->val; return 0; + case V4L2_CID_MPEG_VIDEO_H264_MIN_QP: + solo_enc->qp = ctrl->val; + return 0; case V4L2_CID_MOTION_THRESHOLD: solo_enc->motion_thresh = ctrl->val; if (!solo_enc->motion_global || !solo_enc->motion_enabled) @@ -1260,6 +1263,8 @@ static struct solo_enc_dev *solo_enc_alloc(struct solo_dev *solo_dev, V4L2_CID_SHARPNESS, 0, 15, 1, 0); v4l2_ctrl_new_std(hdl, &solo_ctrl_ops, V4L2_CID_MPEG_VIDEO_GOP_SIZE, 1, 255, 1, solo_dev->fps); + v4l2_ctrl_new_std(hdl, &solo_ctrl_ops, + V4L2_CID_MPEG_VIDEO_H264_MIN_QP, 0, 31, 1, SOLO_DEFAULT_QP); v4l2_ctrl_new_custom(hdl, &solo_motion_threshold_ctrl, NULL); v4l2_ctrl_new_custom(hdl, &solo_motion_enable_ctrl, NULL); v4l2_ctrl_new_custom(hdl, &solo_osd_text_ctrl, NULL);