From patchwork Sat Jul 5 01:31:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Utkin X-Patchwork-Id: 4486091 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C6EA09F36A for ; Sat, 5 Jul 2014 01:32:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0D86F203F1 for ; Sat, 5 Jul 2014 01:32:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C34C203E3 for ; Sat, 5 Jul 2014 01:32:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760203AbaGEBcH (ORCPT ); Fri, 4 Jul 2014 21:32:07 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:46475 "EHLO mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753783AbaGEBcG (ORCPT ); Fri, 4 Jul 2014 21:32:06 -0400 Received: by mail-la0-f48.google.com with SMTP id el20so1501005lab.7 for ; Fri, 04 Jul 2014 18:32:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=4W3DXhewGL0fQkPjPc0ZqcJEfv9kyRg57aSORb2CXRc=; b=oHdSoid/XxdBNf/v1V9FXdTSYYp5R5ZQwN1u74H7ZxNw2Vw1/hA2exOu/f43X9pDmx wHmItNCvMI4WH0uItj8tpuwkMe5IIKR1ny3STMLK2f3zZYM2pYjQ5giIgcit1pPoLg9Z wXH5B2EFiytDq2KeE9EbVqJpmSoXi95Ux51sXqIxLvf5sdYO5TmbdY0WwFM0Ep0VLUTu qyL1E4OnTAA+Q76ch2hTBJUmYxWS8Aa6BEQKD6LLA8p0GUtXgkQgfRnMQfChqOmuUeD+ 3ituY3HnRV8do6jDKW5+p1xJ5XDksmo44F09o1l7nXvrUDxqSk6DEOZyn6asLy1jlsly +v1w== X-Received: by 10.152.23.103 with SMTP id l7mr10879398laf.39.1404523923432; Fri, 04 Jul 2014 18:32:03 -0700 (PDT) Received: from localhost.localdomain (alfa-g11.tenet.odessa.ua. [195.138.73.151]) by mx.google.com with ESMTPSA id uo5sm24267183lbb.6.2014.07.04.18.32.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Jul 2014 18:32:02 -0700 (PDT) From: Andrey Utkin To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Cc: Andrey Utkin Subject: [PATCH] [media] davinci-vpfe: Fix retcode check Date: Sat, 5 Jul 2014 04:31:49 +0300 Message-Id: <1404523909-2058-1-git-send-email-andrey.krieger.utkin@gmail.com> X-Mailer: git-send-email 1.8.3.2 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP See https://bugzilla.kernel.org/show_bug.cgi?id=69071 ---8<--- Use signed type to check correctly for negative error code Reported-by: David Binderman Signed-off-by: Andrey Utkin --- drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c index b2daf5e..e326032 100644 --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c @@ -254,7 +254,7 @@ int config_ipipe_hw(struct vpfe_ipipe_device *ipipe) void __iomem *ipipe_base = ipipe->base_addr; struct v4l2_mbus_framefmt *outformat; u32 color_pat; - u32 ipipe_mode; + int ipipe_mode; u32 data_path; /* enable clock to IPIPE */