From patchwork Wed Jul 9 20:36:03 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuah Khan X-Patchwork-Id: 4519851 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7C351BEEAA for ; Wed, 9 Jul 2014 20:36:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 80727201CE for ; Wed, 9 Jul 2014 20:36:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 310C920145 for ; Wed, 9 Jul 2014 20:36:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751591AbaGIUgY (ORCPT ); Wed, 9 Jul 2014 16:36:24 -0400 Received: from qmta10.emeryville.ca.mail.comcast.net ([76.96.30.17]:33124 "EHLO qmta10.emeryville.ca.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750854AbaGIUgX (ORCPT ); Wed, 9 Jul 2014 16:36:23 -0400 Received: from omta16.emeryville.ca.mail.comcast.net ([76.96.30.72]) by qmta10.emeryville.ca.mail.comcast.net with comcast id QKrS1o0021ZMdJ4AALcPCq; Wed, 09 Jul 2014 20:36:23 +0000 Received: from mail.gonehiking.org ([50.134.149.16]) by omta16.emeryville.ca.mail.comcast.net with comcast id QLc51o00b0MU7Qa8cLc5yD; Wed, 09 Jul 2014 20:36:06 +0000 Received: from lorien.sisa.samsung.com (lorien-wl.internal [192.168.1.40]) by mail.gonehiking.org (Postfix) with ESMTP id F3E203FD48; Wed, 9 Jul 2014 14:36:04 -0600 (MDT) From: Shuah Khan To: m.chehab@samsung.com Cc: Shuah Khan , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: em28xx - remove reset_resume interface Date: Wed, 9 Jul 2014 14:36:03 -0600 Message-Id: <1404938163-27461-1-git-send-email-shuah.kh@samsung.com> X-Mailer: git-send-email 1.9.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1404938183; bh=/n+nykHfBb65W/vtMbtBrt/qNynenRaXQxj19ctW6E4=; h=Received:Received:Received:From:To:Subject:Date:Message-Id; b=LttdOZSS55MrckM5afGm1/TXLpjPNwHqyMkNZqAgcxMQ5jGBuZ1jhxeQRhXaIEpoJ vXeS95oU5eGbplBIjQtVnm8pxL5iijsHP2+URI+H4YVmbM+8ZCXgtaYlT4aqHnwXZY Y9HaMxo7NB884WEsxCaExkrqUlqUr+f4OYdnqv1yFuOAp0h1zX40d93S7jQwuZhnao kKe6IfeTAEGbUh8intNHaeT8cnli7NxHYVgayMckY2EwXMTC0kNVq0KIWdy7kTB5ue 9IwjWV5JvZWjssThJzf/ny7QCOQhZhE5fuXbwu5weUAFfpNHWeWQbdJjqiZiyDUDiC FaDLKhA8C7GUA== Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP em28xx uses resume interface as its reset_resume interface. If usb device is reset during suspend, reset_resume doesn't do the necessary initialization which leads to resume failure. Many systems don't maintain do not maintain suspend current to the USB host controllers during hibernation. Remove reset_resume to allow disconnect to be called followed by device restore sequence. Signed-off-by: Shuah Khan --- drivers/media/usb/em28xx/em28xx-cards.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c index 15ad470..c53fa77 100644 --- a/drivers/media/usb/em28xx/em28xx-cards.c +++ b/drivers/media/usb/em28xx/em28xx-cards.c @@ -3522,7 +3522,6 @@ static struct usb_driver em28xx_usb_driver = { .disconnect = em28xx_usb_disconnect, .suspend = em28xx_usb_suspend, .resume = em28xx_usb_resume, - .reset_resume = em28xx_usb_resume, .id_table = em28xx_id_table, };