diff mbox

gspca_stv06xx: enable button found on some Quickcam Express variant

Message ID 1405083417-20615-1-git-send-email-ao2@ao2.it (mailing list archive)
State New, archived
Headers show

Commit Message

Antonio Ospite July 11, 2014, 12:56 p.m. UTC 
Signed-off-by: Antonio Ospite <ao2@ao2.it>
---
 drivers/media/usb/gspca/stv06xx/stv06xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Hans de Goede July 14, 2014, 10:27 a.m. UTC | #1 
Hi,

On 07/11/2014 02:56 PM, Antonio Ospite wrote:
> Signed-off-by: Antonio Ospite <ao2@ao2.it>

Thanks, I've added this to my tree and send a pull-req for it
to Mauro.

Regards,

Hans

> ---
>  drivers/media/usb/gspca/stv06xx/stv06xx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/usb/gspca/stv06xx/stv06xx.c b/drivers/media/usb/gspca/stv06xx/stv06xx.c
> index 49d209b..6ac93d8 100644
> --- a/drivers/media/usb/gspca/stv06xx/stv06xx.c
> +++ b/drivers/media/usb/gspca/stv06xx/stv06xx.c
> @@ -505,13 +505,13 @@ static int sd_int_pkt_scan(struct gspca_dev *gspca_dev,
>  {
>  	int ret = -EINVAL;
>  
> -	if (len == 1 && data[0] == 0x80) {
> +	if (len == 1 && (data[0] == 0x80 || data[0] == 0x10)) {
>  		input_report_key(gspca_dev->input_dev, KEY_CAMERA, 1);
>  		input_sync(gspca_dev->input_dev);
>  		ret = 0;
>  	}
>  
> -	if (len == 1 && data[0] == 0x88) {
> +	if (len == 1 && (data[0] == 0x88 || data[0] == 0x11)) {
>  		input_report_key(gspca_dev->input_dev, KEY_CAMERA, 0);
>  		input_sync(gspca_dev->input_dev);
>  		ret = 0;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Antonio Ospite Oct. 28, 2014, 2:39 p.m. UTC | #2 
On Mon, 14 Jul 2014 12:27:57 +0200
Hans de Goede <hdegoede@redhat.com> wrote:

> Hi,
> 
> On 07/11/2014 02:56 PM, Antonio Ospite wrote:
> > Signed-off-by: Antonio Ospite <ao2@ao2.it>
> 
> Thanks, I've added this to my tree and send a pull-req for it
> to Mauro.
>

Hi Hans, I still don't see the change in 3.18-rc2, maybe it got lost.

Here is the patchwork link in case you want to pick the change for 3.19:
https://patchwork.linuxtv.org/patch/24732/

Thanks,
   Antonio

> Regards,
> 
> Hans
> 
> > ---
> >  drivers/media/usb/gspca/stv06xx/stv06xx.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/media/usb/gspca/stv06xx/stv06xx.c b/drivers/media/usb/gspca/stv06xx/stv06xx.c
> > index 49d209b..6ac93d8 100644
> > --- a/drivers/media/usb/gspca/stv06xx/stv06xx.c
> > +++ b/drivers/media/usb/gspca/stv06xx/stv06xx.c
> > @@ -505,13 +505,13 @@ static int sd_int_pkt_scan(struct gspca_dev *gspca_dev,
> >  {
> >  	int ret = -EINVAL;
> >  
> > -	if (len == 1 && data[0] == 0x80) {
> > +	if (len == 1 && (data[0] == 0x80 || data[0] == 0x10)) {
> >  		input_report_key(gspca_dev->input_dev, KEY_CAMERA, 1);
> >  		input_sync(gspca_dev->input_dev);
> >  		ret = 0;
> >  	}
> >  
> > -	if (len == 1 && data[0] == 0x88) {
> > +	if (len == 1 && (data[0] == 0x88 || data[0] == 0x11)) {
> >  		input_report_key(gspca_dev->input_dev, KEY_CAMERA, 0);
> >  		input_sync(gspca_dev->input_dev);
> >  		ret = 0;
> >
Antonio Ospite Jan. 6, 2015, 8:59 p.m. UTC | #3 
On Tue, 28 Oct 2014 15:39:41 +0100
Antonio Ospite <ao2@ao2.it> wrote:

> On Mon, 14 Jul 2014 12:27:57 +0200
> Hans de Goede <hdegoede@redhat.com> wrote:
> 
> > Hi,
> > 
> > On 07/11/2014 02:56 PM, Antonio Ospite wrote:
> > > Signed-off-by: Antonio Ospite <ao2@ao2.it>
> > 
> > Thanks, I've added this to my tree and send a pull-req for it
> > to Mauro.
> >
> 
> Hi Hans, I still don't see the change in 3.18-rc2, maybe it got lost.
> 
> Here is the patchwork link in case you want to pick the change for 3.19:
> https://patchwork.linuxtv.org/patch/24732/
> 

Ping.

Still missing in 3.19-rc3.
Can we have it for 3.20?

Thanks,
   Antonio

> > Regards,
> > 
> > Hans
> > 
> > > ---
> > >  drivers/media/usb/gspca/stv06xx/stv06xx.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/media/usb/gspca/stv06xx/stv06xx.c b/drivers/media/usb/gspca/stv06xx/stv06xx.c
> > > index 49d209b..6ac93d8 100644
> > > --- a/drivers/media/usb/gspca/stv06xx/stv06xx.c
> > > +++ b/drivers/media/usb/gspca/stv06xx/stv06xx.c
> > > @@ -505,13 +505,13 @@ static int sd_int_pkt_scan(struct gspca_dev *gspca_dev,
> > >  {
> > >  	int ret = -EINVAL;
> > >  
> > > -	if (len == 1 && data[0] == 0x80) {
> > > +	if (len == 1 && (data[0] == 0x80 || data[0] == 0x10)) {
> > >  		input_report_key(gspca_dev->input_dev, KEY_CAMERA, 1);
> > >  		input_sync(gspca_dev->input_dev);
> > >  		ret = 0;
> > >  	}
> > >  
> > > -	if (len == 1 && data[0] == 0x88) {
> > > +	if (len == 1 && (data[0] == 0x88 || data[0] == 0x11)) {
> > >  		input_report_key(gspca_dev->input_dev, KEY_CAMERA, 0);
> > >  		input_sync(gspca_dev->input_dev);
> > >  		ret = 0;
> > > 
> 
> 
> -- 
> Antonio Ospite
> http://ao2.it
> 
> A: Because it messes up the order in which people normally read text.
>    See http://en.wikipedia.org/wiki/Posting_style
> Q: Why is top-posting such a bad thing?
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Hans de Goede Jan. 15, 2015, 10:54 a.m. UTC | #4 
Hi,

On 06-01-15 21:59, Antonio Ospite wrote:
> On Tue, 28 Oct 2014 15:39:41 +0100
> Antonio Ospite <ao2@ao2.it> wrote:
>
>> On Mon, 14 Jul 2014 12:27:57 +0200
>> Hans de Goede <hdegoede@redhat.com> wrote:
>>
>>> Hi,
>>>
>>> On 07/11/2014 02:56 PM, Antonio Ospite wrote:
>>>> Signed-off-by: Antonio Ospite <ao2@ao2.it>
>>>
>>> Thanks, I've added this to my tree and send a pull-req for it
>>> to Mauro.
>>>
>>
>> Hi Hans, I still don't see the change in 3.18-rc2, maybe it got lost.
>>
>> Here is the patchwork link in case you want to pick the change for 3.19:
>> https://patchwork.linuxtv.org/patch/24732/
>>
>
> Ping.
>
> Still missing in 3.19-rc3.

Yes, weird, I had it in a pull-req for 3.17:

http://git.linuxtv.org/cgit.cgi/hgoede/gspca.git/log/?h=media-for_v3.17

Anyways I've queued it up for 3.20 now.

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/media/usb/gspca/stv06xx/stv06xx.c b/drivers/media/usb/gspca/stv06xx/stv06xx.c
index 49d209b..6ac93d8 100644
--- a/drivers/media/usb/gspca/stv06xx/stv06xx.c
+++ b/drivers/media/usb/gspca/stv06xx/stv06xx.c
@@ -505,13 +505,13 @@  static int sd_int_pkt_scan(struct gspca_dev *gspca_dev,
 {
 	int ret = -EINVAL;
 
-	if (len == 1 && data[0] == 0x80) {
+	if (len == 1 && (data[0] == 0x80 || data[0] == 0x10)) {
 		input_report_key(gspca_dev->input_dev, KEY_CAMERA, 1);
 		input_sync(gspca_dev->input_dev);
 		ret = 0;
 	}
 
-	if (len == 1 && data[0] == 0x88) {
+	if (len == 1 && (data[0] == 0x88 || data[0] == 0x11)) {
 		input_report_key(gspca_dev->input_dev, KEY_CAMERA, 0);
 		input_sync(gspca_dev->input_dev);
 		ret = 0;