| Message ID | 1408726929-3924-1-git-send-email-crope@iki.fi (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri Aug 22 13:02:09 2014, Antti Palosaari wrote: > We should not select SPI bus when sub-driver auto-select is > selected. That option is meant for auto-selecting all possible > ancillary drivers used for selected board driver. Ancillary > drivers should define needed dependencies itself. > > I2C and I2C_MUX are still selected here for a reason described on > commit 347f7a3763601d7b466898d1f10080b7083ac4a3 > > Reverts commit e4462ffc1602d9df21c00a0381dca9080474e27a > > Reported-by: Jeff Mahoney <jeffm@suse.com> > Signed-off-by: Antti Palosaari <crope@iki.fi> > --- > drivers/media/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig > index f60bad4..3c89fcb 100644 > --- a/drivers/media/Kconfig > +++ b/drivers/media/Kconfig > @@ -182,7 +182,6 @@ config MEDIA_SUBDRV_AUTOSELECT > depends on HAS_IOMEM > select I2C > select I2C_MUX > - select SPI > default y > help > By default, a media driver auto-selects all possible ancillary FWIW, in the patch I used locally, I also did a 'select SPI' in the MSI2500 driver since it wouldn't otherwise be obvious that a USB device depends on SPI. -Jeff -- Jeff Mahoney SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/22/14 10:04, Jeff Mahoney wrote: > On Fri Aug 22 13:02:09 2014, Antti Palosaari wrote: >> We should not select SPI bus when sub-driver auto-select is >> selected. That option is meant for auto-selecting all possible >> ancillary drivers used for selected board driver. Ancillary >> drivers should define needed dependencies itself. >> >> I2C and I2C_MUX are still selected here for a reason described on >> commit 347f7a3763601d7b466898d1f10080b7083ac4a3 >> >> Reverts commit e4462ffc1602d9df21c00a0381dca9080474e27a >> >> Reported-by: Jeff Mahoney <jeffm@suse.com> >> Signed-off-by: Antti Palosaari <crope@iki.fi> >> --- >> drivers/media/Kconfig | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig >> index f60bad4..3c89fcb 100644 >> --- a/drivers/media/Kconfig >> +++ b/drivers/media/Kconfig >> @@ -182,7 +182,6 @@ config MEDIA_SUBDRV_AUTOSELECT >> depends on HAS_IOMEM >> select I2C >> select I2C_MUX >> - select SPI >> default y >> help >> By default, a media driver auto-selects all possible ancillary > > FWIW, in the patch I used locally, I also did a 'select SPI' in the > MSI2500 driver since it wouldn't otherwise be obvious that a USB device > depends on SPI. It already has depends on SPI. That should be enough.
On Fri Aug 22 19:34:12 2014, Randy Dunlap wrote: > On 08/22/14 10:04, Jeff Mahoney wrote: >> On Fri Aug 22 13:02:09 2014, Antti Palosaari wrote: >>> We should not select SPI bus when sub-driver auto-select is >>> selected. That option is meant for auto-selecting all possible >>> ancillary drivers used for selected board driver. Ancillary >>> drivers should define needed dependencies itself. >>> >>> I2C and I2C_MUX are still selected here for a reason described on >>> commit 347f7a3763601d7b466898d1f10080b7083ac4a3 >>> >>> Reverts commit e4462ffc1602d9df21c00a0381dca9080474e27a >>> >>> Reported-by: Jeff Mahoney <jeffm@suse.com> >>> Signed-off-by: Antti Palosaari <crope@iki.fi> >>> --- >>> drivers/media/Kconfig | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig >>> index f60bad4..3c89fcb 100644 >>> --- a/drivers/media/Kconfig >>> +++ b/drivers/media/Kconfig >>> @@ -182,7 +182,6 @@ config MEDIA_SUBDRV_AUTOSELECT >>> depends on HAS_IOMEM >>> select I2C >>> select I2C_MUX >>> - select SPI >>> default y >>> help >>> By default, a media driver auto-selects all possible ancillary >> >> FWIW, in the patch I used locally, I also did a 'select SPI' in the >> MSI2500 driver since it wouldn't otherwise be obvious that a USB device >> depends on SPI. > > It already has depends on SPI. That should be enough. > Yeah. My point was more that if you want support for that device, you'd have to know it uses SPI internally already. -Jeff -- Jeff Mahoney SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig index f60bad4..3c89fcb 100644 --- a/drivers/media/Kconfig +++ b/drivers/media/Kconfig @@ -182,7 +182,6 @@ config MEDIA_SUBDRV_AUTOSELECT depends on HAS_IOMEM select I2C select I2C_MUX - select SPI default y help By default, a media driver auto-selects all possible ancillary
We should not select SPI bus when sub-driver auto-select is selected. That option is meant for auto-selecting all possible ancillary drivers used for selected board driver. Ancillary drivers should define needed dependencies itself. I2C and I2C_MUX are still selected here for a reason described on commit 347f7a3763601d7b466898d1f10080b7083ac4a3 Reverts commit e4462ffc1602d9df21c00a0381dca9080474e27a Reported-by: Jeff Mahoney <jeffm@suse.com> Signed-off-by: Antti Palosaari <crope@iki.fi> --- drivers/media/Kconfig | 1 - 1 file changed, 1 deletion(-)