From patchwork Mon Aug 25 17:11:54 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antti Palosaari X-Patchwork-Id: 4775841 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A3B879F38D for ; Mon, 25 Aug 2014 17:12:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 055AB20138 for ; Mon, 25 Aug 2014 17:12:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D1AC2012E for ; Mon, 25 Aug 2014 17:12:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933059AbaHYRM2 (ORCPT ); Mon, 25 Aug 2014 13:12:28 -0400 Received: from mail.kapsi.fi ([217.30.184.167]:48837 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755578AbaHYRMP (ORCPT ); Mon, 25 Aug 2014 13:12:15 -0400 Received: from 85-23-164-39.bb.dnainternet.fi ([85.23.164.39] helo=localhost.localdomain) by mail.kapsi.fi with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1XLxoU-000763-Lu; Mon, 25 Aug 2014 20:12:14 +0300 From: Antti Palosaari To: linux-media@vger.kernel.org Cc: Antti Palosaari Subject: [PATCH 08/12] msi2500: remove unneeded spinlock irq flags initialization Date: Mon, 25 Aug 2014 20:11:54 +0300 Message-Id: <1408986718-3881-8-git-send-email-crope@iki.fi> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1408986718-3881-1-git-send-email-crope@iki.fi> References: <1408986718-3881-1-git-send-email-crope@iki.fi> X-SA-Exim-Connect-IP: 85.23.164.39 X-SA-Exim-Mail-From: crope@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is no need to init flags before calling spin_lock_irqsave(). spin_lock_irqsave is macro which stores value to 'flags'. Signed-off-by: Antti Palosaari --- drivers/media/usb/msi2500/msi2500.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/msi2500/msi2500.c b/drivers/media/usb/msi2500/msi2500.c index 5e3be0e..9e160e8 100644 --- a/drivers/media/usb/msi2500/msi2500.c +++ b/drivers/media/usb/msi2500/msi2500.c @@ -160,7 +160,7 @@ struct msi2500_state { static struct msi2500_frame_buf *msi2500_get_next_fill_buf( struct msi2500_state *s) { - unsigned long flags = 0; + unsigned long flags; struct msi2500_frame_buf *buf = NULL; spin_lock_irqsave(&s->queued_bufs_lock, flags); @@ -559,7 +559,7 @@ static int msi2500_isoc_init(struct msi2500_state *s) /* Must be called with vb_queue_lock hold */ static void msi2500_cleanup_queued_bufs(struct msi2500_state *s) { - unsigned long flags = 0; + unsigned long flags; dev_dbg(s->dev, "\n"); @@ -635,7 +635,7 @@ static void msi2500_buf_queue(struct vb2_buffer *vb) struct msi2500_state *s = vb2_get_drv_priv(vb->vb2_queue); struct msi2500_frame_buf *buf = container_of(vb, struct msi2500_frame_buf, vb); - unsigned long flags = 0; + unsigned long flags; /* Check the device has not disconnected between prep and queuing */ if (unlikely(!s->udev)) {