diff mbox

[v2,27/35,media] s5p-jpeg: Get rid of a warning

Message ID 1409090111-8290-28-git-send-email-m.chehab@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mauro Carvalho Chehab Aug. 26, 2014, 9:55 p.m. UTC
drivers/media/platform/s5p-jpeg/jpeg-hw-s5p.c: In function 's5p_jpeg_clear_int':
drivers/media/platform/s5p-jpeg/jpeg-hw-s5p.c:327:16: warning: variable 'reg' set but not used [-Wunused-but-set-variable]
  unsigned long reg;
                ^

Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
---
 drivers/media/platform/s5p-jpeg/jpeg-hw-s5p.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kamil Debski Sept. 2, 2014, 1:02 p.m. UTC | #1
Hi Mauro,

A subsequent patch by Jacek Anaszewski [1] is resoling this problem in
a better way. If you don't mind I will take his patch.

[1] [1/4] s5p-jpeg: Avoid assigning readl result
    https://patchwork.linuxtv.org/patch/25661/

Best wishes,
Mauro Carvalho Chehab Sept. 2, 2014, 1:51 p.m. UTC | #2
Em Tue, 02 Sep 2014 15:02:43 +0200
Kamil Debski <k.debski@samsung.com> escreveu:

> Hi Mauro,
> 
> A subsequent patch by Jacek Anaszewski [1] is resoling this problem in
> a better way. If you don't mind I will take his patch.

No Problem.

> [1] [1/4] s5p-jpeg: Avoid assigning readl result
>     https://patchwork.linuxtv.org/patch/25661/
> 
> Best wishes,

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/media/platform/s5p-jpeg/jpeg-hw-s5p.c b/drivers/media/platform/s5p-jpeg/jpeg-hw-s5p.c
index 52407d790726..0d37bed088df 100644
--- a/drivers/media/platform/s5p-jpeg/jpeg-hw-s5p.c
+++ b/drivers/media/platform/s5p-jpeg/jpeg-hw-s5p.c
@@ -326,7 +326,7 @@  void s5p_jpeg_clear_int(void __iomem *regs)
 {
 	unsigned long reg;
 
-	reg = readl(regs + S5P_JPGINTST);
+	readl(regs + S5P_JPGINTST);
 	writel(S5P_INT_RELEASE, regs + S5P_JPGCOM);
 	reg = readl(regs + S5P_JPGOPR);
 }