From patchwork Wed Oct 1 05:58:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Schwarzott X-Patchwork-Id: 5009721 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C10149F327 for ; Wed, 1 Oct 2014 05:58:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B315320220 for ; Wed, 1 Oct 2014 05:58:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E37A201F4 for ; Wed, 1 Oct 2014 05:58:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751166AbaJAF6e (ORCPT ); Wed, 1 Oct 2014 01:58:34 -0400 Received: from smtp.gentoo.org ([140.211.166.183]:35869 "EHLO smtp.gentoo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751153AbaJAF6c (ORCPT ); Wed, 1 Oct 2014 01:58:32 -0400 Received: from gauss.fritz.box (aftr-88-217-180-138.dynamic.mnet-online.de [88.217.180.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zzam) by smtp.gentoo.org (Postfix) with ESMTPSA id 6680C3402A4; Wed, 1 Oct 2014 05:58:31 +0000 (UTC) From: Matthias Schwarzott To: linux-media@vger.kernel.org, mchehab@osg.samsung.com, crope@iki.fi Cc: Matthias Schwarzott Subject: [PATCH V2 2/2] si2165: do load firmware without extra header Date: Wed, 1 Oct 2014 07:58:18 +0200 Message-Id: <1412143098-18293-2-git-send-email-zzam@gentoo.org> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1412143098-18293-1-git-send-email-zzam@gentoo.org> References: <1412143098-18293-1-git-send-email-zzam@gentoo.org> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The new file has a different name: dvb-demod-si2165-d.fw Count blocks instead of reading count from extra header. Calculate CRC during upload and compare result to what chip calcuated. Use 0x01 instead of real patch version, because this is only used to check if something was uploaded but not to check the version of it. V2: change firmware filename to lower case. Signed-off-by: Matthias Schwarzott --- drivers/media/dvb-frontends/Kconfig | 1 + drivers/media/dvb-frontends/si2165.c | 105 ++++++++++++++++++------------ drivers/media/dvb-frontends/si2165_priv.h | 2 +- 3 files changed, 66 insertions(+), 42 deletions(-) diff --git a/drivers/media/dvb-frontends/Kconfig b/drivers/media/dvb-frontends/Kconfig index 5a13454..804da4e 100644 --- a/drivers/media/dvb-frontends/Kconfig +++ b/drivers/media/dvb-frontends/Kconfig @@ -66,6 +66,7 @@ config DVB_TDA18271C2DD config DVB_SI2165 tristate "Silicon Labs si2165 based" depends on DVB_CORE && I2C + select CRC_ITU_T default m if !MEDIA_SUBDRV_AUTOSELECT help A DVB-C/T demodulator. diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/media/dvb-frontends/si2165.c index 98ddb49..b64a59c 100644 --- a/drivers/media/dvb-frontends/si2165.c +++ b/drivers/media/dvb-frontends/si2165.c @@ -25,6 +25,7 @@ #include #include #include +#include #include "dvb_frontend.h" #include "dvb_math.h" @@ -327,8 +328,50 @@ static int si2165_wait_init_done(struct si2165_state *state) return ret; } +static int si2165_count_fw_blocks(struct si2165_state *state, const u8 *data, + u32 len) +{ + int block_count = 0; + u32 offset = 0; + + if (len % 4 != 0) { + dev_warn(&state->i2c->dev, "%s: firmware size is not multiple of 4\n", + KBUILD_MODNAME); + return -EINVAL; + } + + while (offset + 4 <= len) { + u8 wordcount = data[offset]; + + if (wordcount < 1 || data[offset+1] || + data[offset+2] || data[offset+3]) { + dev_warn(&state->i2c->dev, + "%s: bad fw data[0..3] = %*ph at offset=%d\n", + KBUILD_MODNAME, 4, data, offset); + return -EINVAL; + } + offset += 8 + 4 * wordcount; + ++block_count; + } + if (offset != len) { + dev_warn(&state->i2c->dev, + "%s: firmware length does not match content, len=%d, offset=%d\n", + KBUILD_MODNAME, len, offset); + return -EINVAL; + } + if (block_count < 6) { + dev_err(&state->i2c->dev, "%s: firmware is too short: Only %d blocks\n", + KBUILD_MODNAME, block_count); + return -EINVAL; + } + block_count -= 6; + dev_info(&state->i2c->dev, "%s: si2165_upload_firmware counted %d main blocks\n", + KBUILD_MODNAME, block_count); + return block_count; +} + static int si2165_upload_firmware_block(struct si2165_state *state, - const u8 *data, u32 len, u32 *poffset, u32 block_count) + const u8 *data, u32 len, u32 *poffset, u32 block_count, u16 *crc) { int ret; u8 buf_ctrl[4] = { 0x00, 0x00, 0x00, 0xc0 }; @@ -374,6 +417,10 @@ static int si2165_upload_firmware_block(struct si2165_state *state, offset += 8; while (wordcount > 0) { + *crc = crc_itu_t_byte(*crc, *(data+offset+3)); + *crc = crc_itu_t_byte(*crc, *(data+offset+2)); + *crc = crc_itu_t_byte(*crc, *(data+offset+1)); + *crc = crc_itu_t_byte(*crc, *(data+offset+0)); ret = si2165_write(state, 0x36c, data+offset, 4); if (ret < 0) goto error; @@ -408,10 +455,9 @@ static int si2165_upload_firmware(struct si2165_state *state) u8 *fw_file; const u8 *data; u32 len; - u32 offset; - u8 patch_version; - u8 block_count; - u16 crc_expected; + u32 offset = 0; + int main_block_count; + u16 crc = 0; switch (state->chip_revcode) { case 0x03: /* revision D */ @@ -437,32 +483,13 @@ static int si2165_upload_firmware(struct si2165_state *state) dev_info(&state->i2c->dev, "%s: downloading firmware from file '%s' size=%d\n", KBUILD_MODNAME, fw_file, len); - if (len % 4 != 0) { - dev_warn(&state->i2c->dev, "%s: firmware size is not multiple of 4\n", - KBUILD_MODNAME); - ret = -EINVAL; - goto error; - } - - /* check header (8 bytes) */ - if (len < 8) { - dev_warn(&state->i2c->dev, "%s: firmware header is missing\n", - KBUILD_MODNAME); - ret = -EINVAL; - goto error; - } - - if (data[0] != 1 || data[1] != 0) { - dev_warn(&state->i2c->dev, "%s: firmware file version is wrong\n", - KBUILD_MODNAME); - ret = -EINVAL; - goto error; + main_block_count = si2165_count_fw_blocks(state, data, len); + if (main_block_count < 0) { + dev_err(&state->i2c->dev, "%s: si2165_upload_firmware: cannot use firmware, skip\n", + KBUILD_MODNAME); + return main_block_count; } - patch_version = data[2]; - block_count = data[4]; - crc_expected = data[7] << 8 | data[6]; - /* start uploading fw */ /* boot/wdog status */ ret = si2165_writereg8(state, 0x0341, 0x00); @@ -488,17 +515,12 @@ static int si2165_upload_firmware(struct si2165_state *state) if (ret < 0) goto error; - /* start right after the header */ - offset = 8; - - dev_info(&state->i2c->dev, "%s: si2165_upload_firmware extracted patch_version=0x%02x, block_count=0x%02x, crc_expected=0x%04x\n", - KBUILD_MODNAME, patch_version, block_count, crc_expected); - - ret = si2165_upload_firmware_block(state, data, len, &offset, 1); + ret = si2165_upload_firmware_block(state, data, len, &offset, 1, &crc); if (ret < 0) goto error; - ret = si2165_writereg8(state, 0x0344, patch_version); + /* patch version, just write a number different from the default 0x00 */ + ret = si2165_writereg8(state, 0x0344, 0x01); if (ret < 0) goto error; @@ -506,9 +528,10 @@ static int si2165_upload_firmware(struct si2165_state *state) ret = si2165_writereg8(state, 0x0379, 0x01); if (ret) return ret; + crc = 0; ret = si2165_upload_firmware_block(state, data, len, - &offset, block_count); + &offset, main_block_count, &crc); if (ret < 0) { dev_err(&state->i2c->dev, "%s: firmare could not be uploaded\n", @@ -521,15 +544,15 @@ static int si2165_upload_firmware(struct si2165_state *state) if (ret) goto error; - if (val16 != crc_expected) { + if (val16 != crc) { dev_err(&state->i2c->dev, "%s: firmware crc mismatch %04x != %04x\n", - KBUILD_MODNAME, val16, crc_expected); + KBUILD_MODNAME, val16, crc); ret = -EINVAL; goto error; } - ret = si2165_upload_firmware_block(state, data, len, &offset, 5); + ret = si2165_upload_firmware_block(state, data, len, &offset, 5, &crc); if (ret) goto error; diff --git a/drivers/media/dvb-frontends/si2165_priv.h b/drivers/media/dvb-frontends/si2165_priv.h index 2b70cf1..52718c3 100644 --- a/drivers/media/dvb-frontends/si2165_priv.h +++ b/drivers/media/dvb-frontends/si2165_priv.h @@ -18,6 +18,6 @@ #ifndef _DVB_SI2165_PRIV #define _DVB_SI2165_PRIV -#define SI2165_FIRMWARE_REV_D "dvb-demod-si2165.fw" +#define SI2165_FIRMWARE_REV_D "dvb-demod-si2165-d.fw" #endif /* _DVB_SI2165_PRIV */