From patchwork Fri Nov 21 18:23:28 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Ruprecht X-Patchwork-Id: 5356941 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id BEC5C9F2F1 for ; Fri, 21 Nov 2014 18:23:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 01323201ED for ; Fri, 21 Nov 2014 18:23:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22E27201B9 for ; Fri, 21 Nov 2014 18:23:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750824AbaKUSXp (ORCPT ); Fri, 21 Nov 2014 13:23:45 -0500 Received: from mail-wi0-f172.google.com ([209.85.212.172]:53148 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750793AbaKUSXo (ORCPT ); Fri, 21 Nov 2014 13:23:44 -0500 Received: by mail-wi0-f172.google.com with SMTP id n3so84760wiv.11 for ; Fri, 21 Nov 2014 10:23:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nIP6Ekdl0hixJGUK6CfSv8GyyzRG9purpJk9wpNWzWY=; b=U20weP2cFvsnPdMLN36MKPa/gxRxaizLiInWueNa6Pdepn0obKqhYHjt4YNj3hjf+E sAMsFmAqkL74KS3CdQ0cQPkW1nyt6kA5pY1jU+sNjv7vRwS1ZAfoyzeLXzxMGOE4Mgs1 kGRVC+CorWEpWuHPsi7p/pS4CcpG0jsjyvcNKbw8iUdglARPhrD/Zh2ECEZEuCw0bGIC OjO4PLKaBb++lOZc2SDizcM7VraMLAjdx5h948egdJbe2SI/uGv0c4veg1kRDghWfiVd jfoupvDlVwSpsc23T0uyLxOXdmDdph9dNcjeuHnIUtjNMwMl5eihSR0rixJyLVq7+aIu Msog== X-Gm-Message-State: ALoCoQm2F0+kgaSvAs6rirCmDS2eHGrTpKAFLOzc/27arXAXndrk8Vu9vkGZ+18NsrvuHHBE6IQ/ X-Received: by 10.180.96.162 with SMTP id dt2mr53450wib.66.1416594223480; Fri, 21 Nov 2014 10:23:43 -0800 (PST) Received: from faui49t.informatik.uni-erlangen.de (faui49t.informatik.uni-erlangen.de. [131.188.42.17]) by mx.google.com with ESMTPSA id cm18sm9053025wjb.25.2014.11.21.10.23.41 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 21 Nov 2014 10:23:42 -0800 (PST) From: Andreas Ruprecht To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, sfr@canb.auug.org.au, Andreas Ruprecht Subject: [PATCH v2] media: pci: smipcie: Fix dependency for DVB_SMIPCIE Date: Fri, 21 Nov 2014 19:23:28 +0100 Message-Id: <1416594208-29553-1-git-send-email-rupran@einserver.de> X-Mailer: git-send-email 1.9.1 In-Reply-To: <20141121161316.23963dc5@recife.lan> References: <20141121161316.23963dc5@recife.lan> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In smipcie.c, the function i2c_bit_add_bus() is called. This function is defined by the I2C bit-banging interfaces enabled with CONFIG_I2C_ALGOBIT. As there was no dependency in Kconfig, CONFIG_I2C_ALGOBIT could be set to "m" while CONFIG_DVB_SMIPCIE was set to "y", resulting in a build error due to an undefined reference. This patch adds the dependency on CONFIG_I2C_ALGOBIT in Kconfig by selecting it when CONFIG_DVB_SMIPCIE is selected. Signed-off-by: Andreas Ruprecht Reported-by: Jim Davis --- drivers/media/pci/smipcie/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/pci/smipcie/Kconfig b/drivers/media/pci/smipcie/Kconfig index 75a2992..57dd124 100644 --- a/drivers/media/pci/smipcie/Kconfig +++ b/drivers/media/pci/smipcie/Kconfig @@ -1,6 +1,7 @@ config DVB_SMIPCIE tristate "SMI PCIe DVBSky cards" depends on DVB_CORE && PCI && I2C + select I2C_ALGOBIT select DVB_M88DS3103 if MEDIA_SUBDRV_AUTOSELECT select MEDIA_TUNER_M88TS2022 if MEDIA_SUBDRV_AUTOSELECT select MEDIA_TUNER_M88RS6000T if MEDIA_SUBDRV_AUTOSELECT