| Message ID | 1417901696-5517-1-git-send-email-crope@iki.fi (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 12/06/2014 10:34 PM, Antti Palosaari wrote: > w_scan complains about missing symbol rate limits: > This dvb driver is *buggy*: the symbol rate limits are undefined - please report to linuxtv.org > > Chip supports 1 to 7.2 MSymbol/s on DVB-C. > > Signed-off-by: Antti Palosaari <crope@iki.fi> Antti, Are you planning to make a pull request of this patch series? It looks good to me, so for this patch series: Acked-by: Hans Verkuil <hans.verkuil@cisco.com> BTW, please add a cover letter whenever you post a patch series (git send-email --compose). It makes it easier to get an overview of what the patch series is all about. Regards, Hans > --- > drivers/media/dvb-frontends/si2168.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c > index ce9ab44..acf0fc3 100644 > --- a/drivers/media/dvb-frontends/si2168.c > +++ b/drivers/media/dvb-frontends/si2168.c > @@ -635,6 +635,8 @@ static const struct dvb_frontend_ops si2168_ops = { > .delsys = {SYS_DVBT, SYS_DVBT2, SYS_DVBC_ANNEX_A}, > .info = { > .name = "Silicon Labs Si2168", > + .symbol_rate_min = 1000000, > + .symbol_rate_max = 7200000, > .caps = FE_CAN_FEC_1_2 | > FE_CAN_FEC_2_3 | > FE_CAN_FEC_3_4 | > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/19/2015 02:24 PM, Hans Verkuil wrote: > On 12/06/2014 10:34 PM, Antti Palosaari wrote: >> w_scan complains about missing symbol rate limits: >> This dvb driver is *buggy*: the symbol rate limits are undefined - please report to linuxtv.org >> >> Chip supports 1 to 7.2 MSymbol/s on DVB-C. >> >> Signed-off-by: Antti Palosaari <crope@iki.fi> > > Antti, > > Are you planning to make a pull request of this patch series? Never mind, I found the pull request :-) I'll mark these patches as accepted in patchwork, to keep patchwork clean. Regards, Hans > > It looks good to me, so for this patch series: > > Acked-by: Hans Verkuil <hans.verkuil@cisco.com> > > BTW, please add a cover letter whenever you post a patch series (git send-email --compose). > It makes it easier to get an overview of what the patch series is all about. > > Regards, > > Hans > >> --- >> drivers/media/dvb-frontends/si2168.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c >> index ce9ab44..acf0fc3 100644 >> --- a/drivers/media/dvb-frontends/si2168.c >> +++ b/drivers/media/dvb-frontends/si2168.c >> @@ -635,6 +635,8 @@ static const struct dvb_frontend_ops si2168_ops = { >> .delsys = {SYS_DVBT, SYS_DVBT2, SYS_DVBC_ANNEX_A}, >> .info = { >> .name = "Silicon Labs Si2168", >> + .symbol_rate_min = 1000000, >> + .symbol_rate_max = 7200000, >> .caps = FE_CAN_FEC_1_2 | >> FE_CAN_FEC_2_3 | >> FE_CAN_FEC_3_4 | >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Moikka! On 01/19/2015 03:24 PM, Hans Verkuil wrote: > On 12/06/2014 10:34 PM, Antti Palosaari wrote: >> w_scan complains about missing symbol rate limits: >> This dvb driver is *buggy*: the symbol rate limits are undefined - please report to linuxtv.org >> >> Chip supports 1 to 7.2 MSymbol/s on DVB-C. >> >> Signed-off-by: Antti Palosaari <crope@iki.fi> > > Antti, > > Are you planning to make a pull request of this patch series? > > It looks good to me, so for this patch series: > > Acked-by: Hans Verkuil <hans.verkuil@cisco.com> > > BTW, please add a cover letter whenever you post a patch series (git send-email --compose). > It makes it easier to get an overview of what the patch series is all about. PULL request is here: https://patchwork.linuxtv.org/patch/27416/ I could send new one if needed, there is missing branch name (new Git version has started blaming it). Are you applying these pull request now? I was expecting Mauro... regards Antti
On 01/19/2015 02:30 PM, Antti Palosaari wrote: > Moikka! > > On 01/19/2015 03:24 PM, Hans Verkuil wrote: >> On 12/06/2014 10:34 PM, Antti Palosaari wrote: >>> w_scan complains about missing symbol rate limits: >>> This dvb driver is *buggy*: the symbol rate limits are undefined - please report to linuxtv.org >>> >>> Chip supports 1 to 7.2 MSymbol/s on DVB-C. >>> >>> Signed-off-by: Antti Palosaari <crope@iki.fi> >> >> Antti, >> >> Are you planning to make a pull request of this patch series? >> >> It looks good to me, so for this patch series: >> >> Acked-by: Hans Verkuil <hans.verkuil@cisco.com> >> >> BTW, please add a cover letter whenever you post a patch series (git send-email --compose). >> It makes it easier to get an overview of what the patch series is all about. > > PULL request is here: > https://patchwork.linuxtv.org/patch/27416/ > > I could send new one if needed, there is missing branch name (new Git > version has started blaming it). It's probably wise to do that (and rebase at the same time). > > Are you applying these pull request now? I was expecting Mauro... I'm cleaning up patchwork, and your (very long) patch series were making it hard to work with patchwork. Regards, Hans > > regards > Antti > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c index ce9ab44..acf0fc3 100644 --- a/drivers/media/dvb-frontends/si2168.c +++ b/drivers/media/dvb-frontends/si2168.c @@ -635,6 +635,8 @@ static const struct dvb_frontend_ops si2168_ops = { .delsys = {SYS_DVBT, SYS_DVBT2, SYS_DVBC_ANNEX_A}, .info = { .name = "Silicon Labs Si2168", + .symbol_rate_min = 1000000, + .symbol_rate_max = 7200000, .caps = FE_CAN_FEC_1_2 | FE_CAN_FEC_2_3 | FE_CAN_FEC_3_4 |
w_scan complains about missing symbol rate limits: This dvb driver is *buggy*: the symbol rate limits are undefined - please report to linuxtv.org Chip supports 1 to 7.2 MSymbol/s on DVB-C. Signed-off-by: Antti Palosaari <crope@iki.fi> --- drivers/media/dvb-frontends/si2168.c | 2 ++ 1 file changed, 2 insertions(+)