| Message ID | 1419367799-14263-48-git-send-email-crope@iki.fi (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 12/23/2014 09:49 PM, Antti Palosaari wrote: > Both mn88472 and mn88473 slave demods are connected to master I2C > bus, not the bus behind master demod I2C gate like tuners. Use > correct bus. > Hello Antti, in my work tree I am still getting i2c errors even with the ir poll workaround (it takes really long time to get them). If I reload the rtl28xxu driver 2 times it starts working again. Could this change be related to such errors ? MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/24/2014 02:45 AM, Benjamin Larsson wrote: > On 12/23/2014 09:49 PM, Antti Palosaari wrote: >> Both mn88472 and mn88473 slave demods are connected to master I2C >> bus, not the bus behind master demod I2C gate like tuners. Use >> correct bus. >> > > Hello Antti, in my work tree I am still getting i2c errors even with the > ir poll workaround (it takes really long time to get them). If I reload > the rtl28xxu driver 2 times it starts working again. Could this change > be related to such errors ? Moikka It could be related. I didn't take many tests, just tested both of my sticks continues working so it is obvious slave demod is not connected to master demod adapter. Tree is here if you wish to test. http://git.linuxtv.org/cgit.cgi/anttip/media_tree.git/log/?h=rtl28xx regards Antti
diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c index c2d377f..0d37d0c 100644 --- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c +++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c @@ -841,7 +841,7 @@ static int rtl2832u_frontend_attach(struct dvb_usb_adapter *adap) info.addr = 0x18; info.platform_data = &mn88472_config; request_module(info.type); - client = i2c_new_device(priv->demod_i2c_adapter, &info); + client = i2c_new_device(&d->i2c_adap, &info); if (client == NULL || client->dev.driver == NULL) { priv->slave_demod = SLAVE_DEMOD_NONE; goto err_slave_demod_failed; @@ -863,7 +863,7 @@ static int rtl2832u_frontend_attach(struct dvb_usb_adapter *adap) info.addr = 0x18; info.platform_data = &mn88473_config; request_module(info.type); - client = i2c_new_device(priv->demod_i2c_adapter, &info); + client = i2c_new_device(&d->i2c_adap, &info); if (client == NULL || client->dev.driver == NULL) { priv->slave_demod = SLAVE_DEMOD_NONE; goto err_slave_demod_failed;
Both mn88472 and mn88473 slave demods are connected to master I2C bus, not the bus behind master demod I2C gate like tuners. Use correct bus. Signed-off-by: Antti Palosaari <crope@iki.fi> --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)