| Message ID | 1421411720-2364-2-git-send-email-olli.salonen@iki.fi (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 01/16/2015 02:35 PM, Olli Salonen wrote: > This patch is based on Antti's silabs branch. > > Add support for 1.7 MHz bandwidth. Supported in all versions of Si2168 according to short data sheets. > > Signed-off-by: Olli Salonen <olli.salonen@iki.fi> Reviewed-by: Antti Palosaari <crope@iki.fi> How about tuner driver filters? Having too wide channel filters reduces some performance, but it still works. It could be even possible 5MHz is smallest filter tuner supports... regards Antti > --- > drivers/media/dvb-frontends/si2168.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c > index 7fef5ab..ec893ee 100644 > --- a/drivers/media/dvb-frontends/si2168.c > +++ b/drivers/media/dvb-frontends/si2168.c > @@ -185,6 +185,8 @@ static int si2168_set_frontend(struct dvb_frontend *fe) > dev_err(&client->dev, "automatic bandwidth not supported"); > goto err; > } > + else if (c->bandwidth_hz <= 2000000) > + bandwidth = 0x02; > else if (c->bandwidth_hz <= 5000000) > bandwidth = 0x05; > else if (c->bandwidth_hz <= 6000000) >
Hi Olli, did you commit this anywhere? Regards, Tycho. Op 16-01-15 om 13:35 schreef Olli Salonen: > This patch is based on Antti's silabs branch. > > Add support for 1.7 MHz bandwidth. Supported in all versions of Si2168 according to short data sheets. > > Signed-off-by: Olli Salonen <olli.salonen@iki.fi> > --- > drivers/media/dvb-frontends/si2168.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c > index 7fef5ab..ec893ee 100644 > --- a/drivers/media/dvb-frontends/si2168.c > +++ b/drivers/media/dvb-frontends/si2168.c > @@ -185,6 +185,8 @@ static int si2168_set_frontend(struct dvb_frontend *fe) > dev_err(&client->dev, "automatic bandwidth not supported"); > goto err; > } > + else if (c->bandwidth_hz <= 2000000) > + bandwidth = 0x02; > else if (c->bandwidth_hz <= 5000000) > bandwidth = 0x05; > else if (c->bandwidth_hz <= 6000000) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Olli, Thanks for the patch. On Fri, Jan 16, 2015 at 12:35 PM, Olli Salonen <olli.salonen@iki.fi> wrote: > This patch is based on Antti's silabs branch. > > Add support for 1.7 MHz bandwidth. Supported in all versions of Si2168 according to short data sheets. > > Signed-off-by: Olli Salonen <olli.salonen@iki.fi> > --- > drivers/media/dvb-frontends/si2168.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c > index 7fef5ab..ec893ee 100644 > --- a/drivers/media/dvb-frontends/si2168.c > +++ b/drivers/media/dvb-frontends/si2168.c > @@ -185,6 +185,8 @@ static int si2168_set_frontend(struct dvb_frontend *fe) > dev_err(&client->dev, "automatic bandwidth not supported"); > goto err; > } > + else if (c->bandwidth_hz <= 2000000) > + bandwidth = 0x02; Please fix checkpatch errors for this patch aswel. Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c index 7fef5ab..ec893ee 100644 --- a/drivers/media/dvb-frontends/si2168.c +++ b/drivers/media/dvb-frontends/si2168.c @@ -185,6 +185,8 @@ static int si2168_set_frontend(struct dvb_frontend *fe) dev_err(&client->dev, "automatic bandwidth not supported"); goto err; } + else if (c->bandwidth_hz <= 2000000) + bandwidth = 0x02; else if (c->bandwidth_hz <= 5000000) bandwidth = 0x05; else if (c->bandwidth_hz <= 6000000)
This patch is based on Antti's silabs branch. Add support for 1.7 MHz bandwidth. Supported in all versions of Si2168 according to short data sheets. Signed-off-by: Olli Salonen <olli.salonen@iki.fi> --- drivers/media/dvb-frontends/si2168.c | 2 ++ 1 file changed, 2 insertions(+)