| Message ID | 1422485265-11231-1-git-send-email-rickard_strandqvist@spectrumdigital.se (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 01/28/2015 11:47 PM, Rickard Strandqvist wrote: > Variable ar assigned a value that is never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck FYI: I've dropped this patch since the vino driver will be removed in 3.20. Regards. Hans > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> > --- > drivers/staging/media/vino/vino.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/media/vino/vino.c b/drivers/staging/media/vino/vino.c > index 2c85357..f43c1ea 100644 > --- a/drivers/staging/media/vino/vino.c > +++ b/drivers/staging/media/vino/vino.c > @@ -2375,7 +2375,6 @@ static irqreturn_t vino_interrupt(int irq, void *dev_id) > next_4_desc = vino->a.next_4_desc; > unsigned int line_count_2, > page_index_2, > - field_counter_2, > start_desc_tbl_2, > next_4_desc_2; > #endif > @@ -2421,7 +2420,6 @@ static irqreturn_t vino_interrupt(int irq, void *dev_id) > #ifdef VINO_DEBUG_INT > line_count_2 = vino->a.line_count; > page_index_2 = vino->a.page_index; > - field_counter_2 = vino->a.field_counter; > start_desc_tbl_2 = vino->a.start_desc_tbl; > next_4_desc_2 = vino->a.next_4_desc; > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/media/vino/vino.c b/drivers/staging/media/vino/vino.c index 2c85357..f43c1ea 100644 --- a/drivers/staging/media/vino/vino.c +++ b/drivers/staging/media/vino/vino.c @@ -2375,7 +2375,6 @@ static irqreturn_t vino_interrupt(int irq, void *dev_id) next_4_desc = vino->a.next_4_desc; unsigned int line_count_2, page_index_2, - field_counter_2, start_desc_tbl_2, next_4_desc_2; #endif @@ -2421,7 +2420,6 @@ static irqreturn_t vino_interrupt(int irq, void *dev_id) #ifdef VINO_DEBUG_INT line_count_2 = vino->a.line_count; page_index_2 = vino->a.page_index; - field_counter_2 = vino->a.field_counter; start_desc_tbl_2 = vino->a.start_desc_tbl; next_4_desc_2 = vino->a.next_4_desc;
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> --- drivers/staging/media/vino/vino.c | 2 -- 1 file changed, 2 deletions(-)