| Message ID | 1424450288-26444-3-git-send-email-k.debski@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/20/2015 05:38 PM, Kamil Debski wrote: > The coda driver interprets a buffer with bytesused equal to 0 as a special > case indicating end-of-stream. After vb2: fix bytesused == 0 handling > (8a75ffb) patch videobuf2 modified the value of bytesused if it was 0. > The allow_zero_bytesused flag was added to videobuf2 to keep > backward compatibility. > > Signed-off-by: Kamil Debski <k.debski@samsung.com> > --- > drivers/media/platform/coda/coda-common.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c > index 6f32e6d..2d23f9a 100644 > --- a/drivers/media/platform/coda/coda-common.c > +++ b/drivers/media/platform/coda/coda-common.c > @@ -1541,6 +1541,13 @@ static int coda_queue_init(struct coda_ctx *ctx, struct vb2_queue *vq) > vq->buf_struct_size = sizeof(struct v4l2_m2m_buffer); > vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY; > vq->lock = &ctx->dev->dev_mutex; > + /* One of means to indicate end-of-stream for coda is to set the s/One of means/One way/ > + * bytesused == 0. However by default videobuf2 handles videobuf s/videobuf/bytesused/ > + * equal to 0 as a special case and changes its value to the size > + * of the buffer. Set the allow_zero_bytesused flag, so > + * that videobuf2 will keep the value of bytesused intact. > + */ > + vq->allow_zero_bytesused = 1; > > return vb2_queue_init(vq); > } > Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c index 6f32e6d..2d23f9a 100644 --- a/drivers/media/platform/coda/coda-common.c +++ b/drivers/media/platform/coda/coda-common.c @@ -1541,6 +1541,13 @@ static int coda_queue_init(struct coda_ctx *ctx, struct vb2_queue *vq) vq->buf_struct_size = sizeof(struct v4l2_m2m_buffer); vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY; vq->lock = &ctx->dev->dev_mutex; + /* One of means to indicate end-of-stream for coda is to set the + * bytesused == 0. However by default videobuf2 handles videobuf + * equal to 0 as a special case and changes its value to the size + * of the buffer. Set the allow_zero_bytesused flag, so + * that videobuf2 will keep the value of bytesused intact. + */ + vq->allow_zero_bytesused = 1; return vb2_queue_init(vq); }
The coda driver interprets a buffer with bytesused equal to 0 as a special case indicating end-of-stream. After vb2: fix bytesused == 0 handling (8a75ffb) patch videobuf2 modified the value of bytesused if it was 0. The allow_zero_bytesused flag was added to videobuf2 to keep backward compatibility. Signed-off-by: Kamil Debski <k.debski@samsung.com> --- drivers/media/platform/coda/coda-common.c | 7 +++++++ 1 file changed, 7 insertions(+)