| Message ID | 1424450288-26444-4-git-send-email-k.debski@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/20/2015 05:38 PM, Kamil Debski wrote: > The s5p-mfc driver interprets a buffer with bytesused equal to 0 as a > special case indicating end-of-stream. After vb2: fix bytesused == 0 > handling (8a75ffb) patch videobuf2 modified the value of bytesused if it > was 0. The allow_zero_bytesused flag was added to videobuf2 to keep > backward compatibility. > > Signed-off-by: Kamil Debski <k.debski@samsung.com> > --- > drivers/media/platform/s5p-mfc/s5p_mfc.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c > index 8e44a59..6b08488 100644 > --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c > @@ -843,6 +843,13 @@ static int s5p_mfc_open(struct file *file) > ret = -ENOENT; > goto err_queue_init; > } > + /* One of means to indicate end-of-stream for MFC is to set the > + * bytesused == 0. However by default videobuf2 handles videobuf Same typos as in patch 3/4. Regards, Hans > + * equal to 0 as a special case and changes its value to the size > + * of the buffer. Set the allow_zero_bytesused flag so that videobuf2 > + * will keep the value of bytesused intact. > + */ > + q->allow_zero_bytesused = 1; > q->mem_ops = &vb2_dma_contig_memops; > q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY; > ret = vb2_queue_init(q); > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index 8e44a59..6b08488 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c @@ -843,6 +843,13 @@ static int s5p_mfc_open(struct file *file) ret = -ENOENT; goto err_queue_init; } + /* One of means to indicate end-of-stream for MFC is to set the + * bytesused == 0. However by default videobuf2 handles videobuf + * equal to 0 as a special case and changes its value to the size + * of the buffer. Set the allow_zero_bytesused flag so that videobuf2 + * will keep the value of bytesused intact. + */ + q->allow_zero_bytesused = 1; q->mem_ops = &vb2_dma_contig_memops; q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY; ret = vb2_queue_init(q);
The s5p-mfc driver interprets a buffer with bytesused equal to 0 as a special case indicating end-of-stream. After vb2: fix bytesused == 0 handling (8a75ffb) patch videobuf2 modified the value of bytesused if it was 0. The allow_zero_bytesused flag was added to videobuf2 to keep backward compatibility. Signed-off-by: Kamil Debski <k.debski@samsung.com> --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 7 +++++++ 1 file changed, 7 insertions(+)