From patchwork Thu Feb 26 21:41:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antti Palosaari X-Patchwork-Id: 5896061 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6D5BABF440 for ; Thu, 26 Feb 2015 21:42:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9CCF020384 for ; Thu, 26 Feb 2015 21:42:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2339203A1 for ; Thu, 26 Feb 2015 21:42:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754215AbbBZVme (ORCPT ); Thu, 26 Feb 2015 16:42:34 -0500 Received: from mail.kapsi.fi ([217.30.184.167]:50424 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754094AbbBZVmd (ORCPT ); Thu, 26 Feb 2015 16:42:33 -0500 Received: from dyn3-82-128-188-110.psoas.suomi.net ([82.128.188.110] helo=localhost.localdomain.localdomain) by mail.kapsi.fi with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1YR6CS-0005rr-C1; Thu, 26 Feb 2015 23:42:28 +0200 From: Antti Palosaari To: linux-media@vger.kernel.org Cc: Jurgen Kramer , , Antti Palosaari Subject: [PATCHv2] Si2168: increase timeout to fix firmware loading Date: Thu, 26 Feb 2015 23:41:54 +0200 Message-Id: <1424986914-5472-1-git-send-email-crope@iki.fi> X-Mailer: git-send-email 2.1.0 X-SA-Exim-Connect-IP: 82.128.188.110 X-SA-Exim-Mail-From: crope@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Jurgen Kramer Increase si2168 cmd execute timeout to prevent firmware load failures. Tests shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw' firmware. Increase timeout to a safe value of 70ms. Cc: # v3.16+ Signed-off-by: Jurgen Kramer Reviewed-by: Antti Palosaari Signed-off-by: Antti Palosaari --- Changes since v1: * I added my SOB Patch for stable 3.16+ That patch is already applied to master as commit 551c33e729f654ecfaed00ad399f5d2a631b72cb There was some mistake and Cc stable tag I added to patchwork [1] was lost. [1] https://patchwork.linuxtv.org/patch/27382/ --- drivers/media/dvb-frontends/si2168.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c index 2e3cdcf..fbc1fa8 100644 --- a/drivers/media/dvb-frontends/si2168.c +++ b/drivers/media/dvb-frontends/si2168.c @@ -39,7 +39,7 @@ static int si2168_cmd_execute(struct si2168 *s, struct si2168_cmd *cmd) if (cmd->rlen) { /* wait cmd execution terminate */ - #define TIMEOUT 50 + #define TIMEOUT 70 timeout = jiffies + msecs_to_jiffies(TIMEOUT); while (!time_after(jiffies, timeout)) { ret = i2c_master_recv(s->client, cmd->args, cmd->rlen);