| Message ID | 1425764475-27691-13-git-send-email-sakari.ailus@iki.fi (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Sakari, Thank you for the patch. (CC'ing Sylwester) On Saturday 07 March 2015 23:41:09 Sakari Ailus wrote: > Add lane-polarity property to endpoint nodes. This essentially tells that > the order of the differential signal wires is inverted. > > Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi> > --- > Documentation/devicetree/bindings/media/video-interfaces.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt > b/Documentation/devicetree/bindings/media/video-interfaces.txt index > 571b4c6..058d1e6 100644 > --- a/Documentation/devicetree/bindings/media/video-interfaces.txt > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt > @@ -106,6 +106,11 @@ Optional endpoint properties > - link-frequencies: Allowed data bus frequencies. For MIPI CSI-2, for > instance, this is the actual frequency of the bus, not bits per clock per > lane value. An array of 64-bit unsigned integers. > +- lane-polarity: an array of polarities of the lanes starting from the > clock > + lane and followed by the data lanes in the same order as in data-lanes. > + Valid values are 0 (normal) and 1 (inverted). Would it make sense to add #define's for this ? > The length of the array > + should be the combined length of data-lanes and clock-lanes > properties. > + This property is valid for serial busses only. You should also document what happens when the property is omitted. > Example
Hi Laurent, On Sun, Mar 08, 2015 at 01:46:02AM +0200, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > (CC'ing Sylwester) > > On Saturday 07 March 2015 23:41:09 Sakari Ailus wrote: > > Add lane-polarity property to endpoint nodes. This essentially tells that > > the order of the differential signal wires is inverted. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi> > > --- > > Documentation/devicetree/bindings/media/video-interfaces.txt | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt > > b/Documentation/devicetree/bindings/media/video-interfaces.txt index > > 571b4c6..058d1e6 100644 > > --- a/Documentation/devicetree/bindings/media/video-interfaces.txt > > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt > > @@ -106,6 +106,11 @@ Optional endpoint properties > > - link-frequencies: Allowed data bus frequencies. For MIPI CSI-2, for > > instance, this is the actual frequency of the bus, not bits per clock per > > lane value. An array of 64-bit unsigned integers. > > +- lane-polarity: an array of polarities of the lanes starting from the > > clock > > + lane and followed by the data lanes in the same order as in data-lanes. > > + Valid values are 0 (normal) and 1 (inverted). > > Would it make sense to add #define's for this ? Good question. I don't really have too much of an opinion. I think I'd just use a number until someone else needs this. :-) > > The length of the array > > + should be the combined length of data-lanes and clock-lanes > > properties. > > + This property is valid for serial busses only. > > You should also document what happens when the property is omitted. Will add.
diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt index 571b4c6..058d1e6 100644 --- a/Documentation/devicetree/bindings/media/video-interfaces.txt +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt @@ -106,6 +106,11 @@ Optional endpoint properties - link-frequencies: Allowed data bus frequencies. For MIPI CSI-2, for instance, this is the actual frequency of the bus, not bits per clock per lane value. An array of 64-bit unsigned integers. +- lane-polarity: an array of polarities of the lanes starting from the clock + lane and followed by the data lanes in the same order as in data-lanes. + Valid values are 0 (normal) and 1 (inverted). The length of the array + should be the combined length of data-lanes and clock-lanes properties. + This property is valid for serial busses only. Example
Add lane-polarity property to endpoint nodes. This essentially tells that the order of the differential signal wires is inverted. Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi> --- Documentation/devicetree/bindings/media/video-interfaces.txt | 5 +++++ 1 file changed, 5 insertions(+)