From patchwork Mon Jun 8 09:02:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacek Anaszewski X-Patchwork-Id: 6563691 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E30EA9F1C1 for ; Mon, 8 Jun 2015 09:03:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F1E53203E6 for ; Mon, 8 Jun 2015 09:03:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E21C0203E3 for ; Mon, 8 Jun 2015 09:03:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932162AbbFHJDC (ORCPT ); Mon, 8 Jun 2015 05:03:02 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:43327 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932111AbbFHJDA (ORCPT ); Mon, 8 Jun 2015 05:03:00 -0400 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NPM018L2BSV6RD0@mailout2.samsung.com>; Mon, 08 Jun 2015 18:02:55 +0900 (KST) X-AuditID: cbfee61b-f79416d0000014c0-6f-55755a3f67b8 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 10.F3.05312.F3A55755; Mon, 8 Jun 2015 18:02:55 +0900 (KST) Received: from AMDC2362.DIGITAL.local ([106.120.53.23]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NPM001AYBS2ERZ0@mmp2.samsung.com>; Mon, 08 Jun 2015 18:02:55 +0900 (KST) From: Jacek Anaszewski To: linux-leds@vger.kernel.org, linux-media@vger.kernel.org Cc: kyungmin.park@samsung.com, pavel@ucw.cz, cooloney@gmail.com, rpurdie@rpsys.net, sakari.ailus@iki.fi, s.nawrocki@samsung.com, Jacek Anaszewski , devicetree@vger.kernel.org Subject: [PATCH v10 4/8] DT: aat1290: Document handling external strobe sources Date: Mon, 08 Jun 2015 11:02:21 +0200 Message-id: <1433754145-12765-5-git-send-email-j.anaszewski@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1433754145-12765-1-git-send-email-j.anaszewski@samsung.com> References: <1433754145-12765-1-git-send-email-j.anaszewski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKLMWRmVeSWpSXmKPExsVy+t9jQV37qNJQg76fBhZHd05ksph/5Byr Re/V54wWZ5vesFtsfbOO0aJnw1ZWi7unjrJZ7N71lNXi8Jt2Vosz+1eyOXB57Jx1l93j8NeF LB575v9g9ejbsorRY8Xq7+wenzfJBbBFcdmkpOZklqUW6dslcGW8PGBQ8EOiYs39c4wNjEdF uhg5OSQETCS6Xx5hgbDFJC7cW8/WxcjFISQwnVGi/eF2RgjnJ6PE6SPHmUGq2AQMJX6+eM0E YosIWEvMOjQdrJtZ4AyjxL992iC2sIC/xO7d18DqWQRUJQ7dagGr5xXwkFi0pRdoAwfQNgWJ OZNsQMKcAp4S+5v3M4GEhYBK1k8MmsDIu4CRYRWjaGpBckFxUnqukV5xYm5xaV66XnJ+7iZG cOA9k97BuKrB4hCjAAejEg/vgUUloUKsiWXFlbmHGCU4mJVEeJksSkOFeFMSK6tSi/Lji0pz UosPMUpzsCiJ857M9wkVEkhPLEnNTk0tSC2CyTJxcEo1MEaui0yQSFqk3ppx4WR/BM8vidWW Bjv2CQefFD8t8zsyenFTnf3f276mDzfF7NsvlpuoEXQ6ep3U98kTvP+slHu867gDswOf1iTW sNtLP2u/+Lx6bVzboq6zS6y9p13Rur/lSDITW1TqxP7wo2yqZtuq3jlceJCqUCKU1VK/fM1W dvHsCZO36CqxFGckGmoxFxUnAgA64z7nOAIAAA== Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds documentation for a pinctrl-names property. The property, when present, is used for switching the source of the strobe signal for the device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus Cc: devicetree@vger.kernel.org --- .../devicetree/bindings/leds/leds-aat1290.txt | 36 ++++++++++++++++++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/leds/leds-aat1290.txt b/Documentation/devicetree/bindings/leds/leds-aat1290.txt index ef88b9c..c05ed91 100644 --- a/Documentation/devicetree/bindings/leds/leds-aat1290.txt +++ b/Documentation/devicetree/bindings/leds/leds-aat1290.txt @@ -2,7 +2,9 @@ The device is controlled through two pins: FL_EN and EN_SET. The pins when, asserted high, enable flash strobe and movie mode (max 1/2 of flash current) -respectively. +respectively. In order to add a capability of selecting the strobe signal source +(e.g. CPU or camera sensor) there is an additional switch required, independent +of the flash chip. The switch is controlled with pin control. Required properties: @@ -10,6 +12,13 @@ Required properties: - flen-gpios : Must be device tree identifier of the flash device FL_EN pin. - enset-gpios : Must be device tree identifier of the flash device EN_SET pin. +Optional properties: +- pinctrl-names : Must contain entries: "default", "host", "isp". Entries + "default" and "host" must refer to the same pin configuration + node, which sets the host as a strobe signal provider. Entry + "isp" must refer to the pin configuration node, which sets the + ISP as a strobe signal provider. + A discrete LED element connected to the device must be represented by a child node - see Documentation/devicetree/bindings/leds/common.txt. @@ -25,13 +34,22 @@ Required properties of the LED child node: Optional properties of the LED child node: - label : see Documentation/devicetree/bindings/leds/common.txt -Example (by Ct = 220nF, Rset = 160kohm): +Example (by Ct = 220nF, Rset = 160kohm and exynos4412-trats2 board with +a switch that allows for routing strobe signal either from the host or from +the camera sensor): + +#include "exynos4412.dtsi" aat1290 { compatible = "skyworks,aat1290"; flen-gpios = <&gpj1 1 GPIO_ACTIVE_HIGH>; enset-gpios = <&gpj1 2 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default", "host", "isp"; + pinctrl-0 = <&camera_flash_host>; + pinctrl-1 = <&camera_flash_host>; + pinctrl-2 = <&camera_flash_isp>; + camera_flash: flash-led { label = "aat1290-flash"; led-max-microamp = <520833>; @@ -39,3 +57,17 @@ aat1290 { flash-timeout-us = <1940000>; }; }; + +&pinctrl_0 { + camera_flash_host: camera-flash-host { + samsung,pins = "gpj1-0"; + samsung,pin-function = <1>; + samsung,pin-val = <0>; + }; + + camera_flash_isp: camera-flash-isp { + samsung,pins = "gpj1-0"; + samsung,pin-function = <1>; + samsung,pin-val = <1>; + }; +};